Review main Merged

93616[TASK] Add test for database-stored form rendering in frontend

Josua Vogel CR +2 V +2 Normal +145 −0 updated 04/13/26, 13:04

Commit message

Add a functional test that verifies database-stored forms
render correctly in the frontend without a backend user session.

This serves as a regression test for the bugfix that skips
backend permission checks in DatabaseStorageAdapter::read()
when handling frontend requests. Without this fix, forms stored
in the database could not be displayed in the frontend because
the permission check required a backend user which is not
available in frontend context.

The test performs a full HTTP request cycle:
- Requests a page containing a form_formframework content element
  that references a database-stored form (persistenceIdentifier=UID)
- Verifies the form is rendered in the page markup
- Submits the form via POST and verifies the Confirmation finisher
  message is displayed

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 4

Files 3

Review log 1320

  1. Josua Vogel uploaded patch set 1 04/10/26, 11:02

  2. Josua Vogel updated the commit message in patch set 2 04/10/26, 11:06

  3. core-ci voted on patch set 1 V -1 04/10/26, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99913

  4. core-ci voted on patch set 2 V -1 04/10/26, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99914

  5. Stefan Bürk commented on patch set 3 V -1 04/11/26, 23:16

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V -1 04/11/26, 23:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99993

  7. Josua Vogel uploaded patch set 4 V -1 04/12/26, 16:27

  8. Josua Vogel uploaded patch set 5 04/12/26, 16:28

  9. core-ci voted on patch set 4 V -1 04/12/26, 16:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100026

  10. core-ci voted on patch set 5 V -1 04/12/26, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100027

  11. Josua Vogel rebased onto patch set 6 V -1 04/13/26, 11:14

  12. core-ci voted on patch set 6 V -1 04/13/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100074

  13. Oliver Klee commented on patch set 6 04/13/26, 11:28

    DatabaseStoredFormTest.php:32

    We need to drop this line for the CGL CI job to pass.
  14. Josua Vogel commented on patch set 7 V -1 04/13/26, 11:30

    Published edit on patch set 6.
  15. Josua Vogel commented on patch set 7 04/13/26, 11:30

    DatabaseStoredFormTest.php:32 Reply

    thx!
  16. core-ci voted on patch set 7 V +1 04/13/26, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100075

  17. Oliver Klee voted on patch set 7 V +1 04/13/26, 11:57

  18. Garvin Hicking commented on patch set 7 CR +1 V +1 04/13/26, 12:02

    Good stuff!
  19. Georg Ringer voted on patch set 7 CR +2 V +2 04/13/26, 13:04

  20. Georg Ringer merged patch set 8 04/13/26, 13:04