Review main Merged

93618[BUGFIX] Respect `suggests` package constraints

Stefan Bürk CR +2 V +2 Normal +82 −84 updated 04/12/26, 19:32

Commit message

Convert Composer names in suggested constraints to package
keys, matching the behavior used for dependency constraints.

After removing `ext_emconf.php`, constraints now contain
Composer names instead of package keys.

Updated the test to reflect both Core PackageManager ordering
and Testing Framework ordering (the latter was not affected
by this bug).

Also updated the test to always load all framework packages,
resolving a remaining `TODO`.

This is now easily possible due to the `framework-packages.php`
file used for dependency resolution.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1523

  1. Stefan Bürk uploaded patch set 1 04/10/26, 19:41

  2. Stefan Bürk uploaded patch set 2 04/10/26, 19:48

  3. core-ci voted on patch set 1 V -1 04/10/26, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99932

  4. core-ci voted on patch set 2 V -1 04/10/26, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99933

  5. core-ci commented on patch set 2 04/10/26, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99933

  6. core-ci commented on patch set 2 04/10/26, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99933

  7. core-ci voted on patch set 2 V +1 04/10/26, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99933

  8. Helmut Hummel commented on patch set 2 CR -1 04/11/26, 08:20

    This change is ready for review.

    PackageManager.php:781

    this check should be avoided and duplicates the check in the method
  9. Helmut Hummel uploaded patch set 3 CR -1 V +1 04/11/26, 10:18

  10. Oliver Klee voted on patch set 3 V +1 04/11/26, 10:42

  11. core-ci voted on patch set 3 V +1 04/11/26, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99956

  12. Stefan Bürk uploaded patch set 4 V +1 04/11/26, 19:34

  13. Stefan Bürk commented on patch set 4 04/11/26, 19:36

    PackageManager.php:781 Reply

    Done
  14. core-ci voted on patch set 4 V +1 04/11/26, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99989

  15. Oliver Klee voted on patch set 4 V +1 04/11/26, 21:00

  16. Stefan Bürk updated the commit message in patch set 5 V +1 04/12/26, 11:05

  17. Anja Leichsenring voted on patch set 5 CR +1 V +1 04/12/26, 11:15

  18. Garvin Hicking voted on patch set 5 CR +1 V +1 04/12/26, 11:42

  19. core-ci voted on patch set 5 V +1 04/12/26, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100014

  20. Christian Kuhn voted on patch set 5 CR +1 04/12/26, 12:01

  21. Georg Ringer voted on patch set 5 CR +1 V +1 04/12/26, 14:42

  22. Helmut Hummel voted on patch set 5 CR +2 V +2 04/12/26, 19:32

  23. Helmut Hummel merged patch set 6 04/12/26, 19:32