Review main Merged

93619[BUGFIX] Avoid TypeError in SystemInformationToolbarItem when exec fails

Benjamin Kott CR +2 V +2 Easy +8 −3 updated 04/12/26, 08:50

Commit message

`CommandUtility::exec()` can return false when the process fails,
but `trim()` requires a `string` argument since PHP 8.1. Check the
return value before passing it to `trim()` to prevent a TypeError.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Benjamin Kott uploaded patch set 1 04/10/26, 23:05

  2. core-ci voted on patch set 1 V +1 04/10/26, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99934

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/11/26, 05:55

  4. Oliver Klee voted on patch set 2 CR +1 04/11/26, 05:56

  5. core-ci voted on patch set 2 V +1 04/11/26, 06:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99950

  6. Benjamin Franzke voted on patch set 2 CR +1 V +1 04/11/26, 06:13

  7. Christian Kuhn commented on patch set 2 CR +1 V +1 04/11/26, 07:07

    interesting. this must have been in there for quite some time already.
  8. Garvin Hicking commented on patch set 2 04/11/26, 07:19

    Reply

    Then we could/should backport it to 13.4?
  9. Christian Kuhn commented on patch set 2 04/11/26, 07:53

    Reply

    thought about this too, unsure. in the end, this has never been reported so it looks edgy (the call before actually tests git is there). go ahead if you want, it's probably safe in v13 as well.
  10. Garvin Hicking commented on patch set 2 CR +1 V +1 04/11/26, 08:47

    Reply

    I'll leave it up for Benji to decide.
  11. Benjamin Kott commented on patch set 2 04/11/26, 11:35

    Reply

    I've never had any problems with that, it popped up during my wasm tests, we surely can backport this. just needed this patch to get my stuff running
  12. Stefan Bürk commented on patch set 2 CR +1 V +1 04/11/26, 23:18

    Reply

    I would limit this to main for now. @garvin@hick.ing okay for you to keep that main only ?
  13. Garvin Hicking commented on patch set 2 CR +2 V +2 04/12/26, 08:50

    Reply

    Done
  14. Garvin Hicking merged patch set 3 04/12/26, 08:50