93619[BUGFIX] Avoid TypeError in SystemInformationToolbarItem when exec fails
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Oliver Klee +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Benjamin Kott uploaded patch set 1 04/10/26, 23:05
-
core-ci voted on patch set 1 V +1 04/10/26, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99934
-
Oliver Klee updated the commit message in patch set 2
V +104/11/26, 05:55 -
Oliver Klee voted on patch set 2 CR +1 04/11/26, 05:56
-
core-ci voted on patch set 2 V +1 04/11/26, 06:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99950
-
Benjamin Franzke voted on patch set 2 CR +1 V +1 04/11/26, 06:13
-
Christian Kuhn commented on patch set 2 CR +1 V +1 04/11/26, 07:07
interesting. this must have been in there for quite some time already. -
Garvin Hicking commented on patch set 2 04/11/26, 07:19
Reply
Then we could/should backport it to 13.4? -
Christian Kuhn commented on patch set 2 04/11/26, 07:53
Reply
thought about this too, unsure. in the end, this has never been reported so it looks edgy (the call before actually tests git is there). go ahead if you want, it's probably safe in v13 as well. -
Garvin Hicking commented on patch set 2 CR +1 V +1 04/11/26, 08:47
Reply
I'll leave it up for Benji to decide. -
Benjamin Kott commented on patch set 2 04/11/26, 11:35
Reply
I've never had any problems with that, it popped up during my wasm tests, we surely can backport this. just needed this patch to get my stuff running -
Stefan Bürk commented on patch set 2 CR +1 V +1 04/11/26, 23:18
Reply
I would limit this to main for now. @garvin@hick.ing okay for you to keep that main only ? -
Garvin Hicking commented on patch set 2 CR +2 V +2 04/12/26, 08:50
Reply
Done -
Garvin Hicking merged patch set 3 04/12/26, 08:50