93621[TASK] Harmonize native function call style
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 26
- Build/php-cs-fixer/config.php+6 −0
- Build/Scripts/phpIntegrityChecks/NamespaceChecker.php+1 −1
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+1 −1
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/DataProviderCollection.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Toolbar/AttributesViewHelper.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/Totp.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BlowfishPasswordHash.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Md5PasswordHash.php+1 −1
- typo3/sysext/core/Classes/Error/DebugExceptionHandler.php+1 −1
- typo3/sysext/core/Classes/Messenger/TransportLocator.php+1 −1
- typo3/sysext/core/Classes/Page/ContentSlideMode.php+1 −1
- typo3/sysext/core/Classes/Routing/BestUrlMatcher.php+3 −3
- typo3/sysext/core/Classes/Routing/RouteSorter.php+11 −11
- typo3/sysext/core/Classes/Utility/File/FileSystem.php+5 −5
- typo3/sysext/core/Tests/Functional/Cache/Backend/FileBackendTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Command/CliCommandTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularLocalize/AbstractActionTestCase.php+1 −1
- typo3/sysext/extbase/Classes/Attribute/Validate.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/ConstraintDecoratingValidator.php+1 −1
Show 6 more files
- typo3/sysext/frontend/Tests/Functional/Controller/ErrorControllerTest.php+4 −4
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_request_mirror/Classes/Middleware/RequestMirror.php+1 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+1 −1
- typo3/sysext/lowlevel/Classes/Controller/QuerySearchController.php+1 −1
- typo3/sysext/recycler/Tests/Functional/Controller/RecyclerAjaxControllerTest.php+3 −3
- typo3/sysext/scheduler/Tests/Functional/Migration/SchedulerDatabaseStorageMigrationTest.php+2 −2
Review log 1115
-
Oliver Klee uploaded patch set 1 04/11/26, 06:24
-
Oliver Klee updated the commit message in patch set 2 04/11/26, 06:25
-
core-ci voted on patch set 1 V +1 04/11/26, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99951
-
core-ci voted on patch set 2 V +1 04/11/26, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99952
-
Garvin Hicking commented on patch set 2 04/11/26, 06:58
```suggestion Using a leading backslash very slightly improves performance ``` -
Garvin Hicking updated the commit message in patch set 3
V +104/11/26, 06:59 -
Garvin Hicking commented on patch set 3 CR +1 V +1 04/11/26, 07:04
Reply
Fix applied. -
core-ci voted on patch set 3 V -1 04/11/26, 07:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99953
-
Christian Kuhn commented on patch set 3 04/11/26, 07:25
when i apply the patch, go to Avatar.php and add a backlash in front of an \sprintf() or \get_debug_type(), i'd expect runTests.sh -s phpstan to mumble on it. that's not the case. is my expectation incorrect? -
Garvin Hicking commented on patch set 3 04/11/26, 07:27
Reply
The affected config is cs-fixer, so pre-merge commit. Not phpstan. Haven't checked but I believe these style checks are also executed in CI? -
core-ci voted on patch set 3 V +1 04/11/26, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99953
-
Christian Kuhn commented on patch set 3 04/11/26, 07:47
Reply
lol. foo. sorry. -
Christian Kuhn commented on patch set 3 CR +1 V +1 04/11/26, 07:48
Reply
works. upvoted. thx! -
Christian Kuhn voted on patch set 3 CR +2 V +2 04/11/26, 07:51
-
Christian Kuhn merged patch set 4 04/11/26, 07:51