Review main Merged

93624[TASK] Deprecate GU::locationHeaderUrl() without request

Christian Kuhn CR +2 V +2 Normal +165 −84 updated 04/11/26, 13:30

Commit message

Similar to #109523 and #109544, GeneralUtility::locationHeaderUrl()
hides a dependency on the current request by falling back to
GeneralUtility::getIndpEnv(). The patch extends the signature with
an optional PSR-7 request argument and deprecates calls without it.

Core callers are updated. Some cases - especially when FAL is
involved - fallback to $GLOBALS['TYPO3_REQUEST'], which at least
makes the dependency more obvious for now.

An extension scanner entry flags third-party code.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 21

Show 1 more file

Review log 1015

  1. Christian Kuhn uploaded patch set 1 04/11/26, 10:32

  2. Oliver Klee voted on patch set 1 CR +1 04/11/26, 10:44

  3. core-ci voted on patch set 1 V -1 04/11/26, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99959

  4. Christian Kuhn uploaded patch set 2 CR +1 V -1 04/11/26, 11:04

  5. Christian Kuhn uploaded patch set 3 04/11/26, 11:04

  6. core-ci voted on patch set 2 V -1 04/11/26, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99960

  7. core-ci voted on patch set 3 V -1 04/11/26, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99961

  8. Christian Kuhn uploaded patch set 4 V -1 04/11/26, 11:23

  9. core-ci voted on patch set 4 V -1 04/11/26, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99962

  10. Christian Kuhn uploaded patch set 5 V -1 04/11/26, 11:41

  11. core-ci voted on patch set 5 V +1 04/11/26, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99965

  12. Oliver Klee voted on patch set 5 CR +1 V +1 04/11/26, 12:15

  13. Stefan Bürk voted on patch set 5 CR +1 V +1 04/11/26, 12:40

  14. Stefan Bürk voted on patch set 5 CR +2 V +2 04/11/26, 13:30

  15. Stefan Bürk merged patch set 6 04/11/26, 13:30