Review main Merged

93626[BUGFIX] Restore URL rewriting for inline CSS in PageRenderer

Helmut Hummel CR +2 V +2 Normal +123 −102 updated 04/12/26, 14:40

Commit message

After switching `PageRenderer` to system resource identifiers for
internal stylesheet and JS handling, inlined CSS files were no longer
processed correctly by `RelativeCssPathFixer`.

The previous implementation resolved inline stylesheets via
absolute file paths and rewrote relative `url()` and `@import`
references based on the file location. With system resources,
that path-based handling no longer works reliably, especially for
resources addressed by resource identifiers instead of local file
system paths.

To fix this, inline CSS processing now works with
`SystemResourceInterface` instances and passes the current request
context to `RelativeCssPathFixer`. The fixer is adjusted to resolve
referenced assets as public resources and generate their final public
URIs through the system resource publishing API.

This restores correct rewriting of relative asset references in
inlined CSS for both package resources and published resources.

`RelativeCssPathFixer` is internal API. Adapting its constructor and
method signature is therefore not considered breaking.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 913

  1. Helmut Hummel uploaded patch set 1 04/11/26, 12:53

  2. Helmut Hummel uploaded patch set 2 04/11/26, 12:57

  3. Helmut Hummel updated the commit message in patch set 3 04/11/26, 13:01

  4. core-ci voted on patch set 2 V +1 04/11/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99969

  5. core-ci voted on patch set 3 V +1 04/11/26, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99970

  6. Oliver Klee updated the commit message in patch set 4 V +1 04/11/26, 13:14

  7. core-ci voted on patch set 4 V +1 04/11/26, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99971

  8. core-ci voted on patch set 1 V -1 04/11/26, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99967

  9. Garvin Hicking commented on patch set 4 04/11/26, 18:31

    This works for me (composer environment), thanks!
  10. Garvin Hicking voted on patch set 4 CR +1 V +1 04/11/26, 18:31

  11. Oliver Klee voted on patch set 4 V +1 04/11/26, 18:34

  12. Georg Ringer voted on patch set 4 CR +2 V +2 04/12/26, 14:40

  13. Georg Ringer merged patch set 5 04/12/26, 14:40