93627[TASK] Deprecate GeneralUtility::getIndpEnv()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 4
Files 6
- typo3/sysext/core/Classes/Http/NormalizedParams.php+0 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+34 −25
- typo3/sysext/core/Documentation/Changelog/14.3/Deprecation-109551-GeneralUtilityGetIndpEnv.rst4new+56 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+4 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/RequestBuilderTest.php+29 −28
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1013
-
Christian Kuhn uploaded patch set 1 04/11/26, 16:21
-
core-ci voted on patch set 1 V +1 04/11/26, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99973
-
Christian Kuhn uploaded patch set 2
V +104/12/26, 08:00 -
core-ci voted on patch set 2 V -1 04/12/26, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100012
-
core-ci voted on patch set 2 V +1 04/12/26, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100012
-
Garvin Hicking commented on patch set 2 04/12/26, 10:17
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 04/12/26, 10:37
-
Stefan Bürk voted on patch set 2 CR +1 V +1 04/12/26, 10:56
-
Christian Kuhn commented on patch set 2 04/12/26, 10:59
Deprecation-109551-GeneralUtilityGetIndpEnv.rst:40Replymmmh. i think most core API hands over request by now. the areas we work around in core are often rather internal and/or low level. i guess globals['typo3_request'] is well known, and i wouldn't want to hammer this even deeper into peoples minds since it will phase out slowly as well. i think it would be better when issues are raised where people still actively need request, don't get one, and request changes. this would help us to see where active actions for extensions need to be taken. as such, i prefer to abstain from documenting this option here, since it is non mid-term. -
Christian Kuhn commented on patch set 2 04/12/26, 11:00
Deprecation-109551-GeneralUtilityGetIndpEnv.rst:40Replyi don't insist on this view, though. if such a hint is important to you, feel free to adapt the change. -
Garvin Hicking commented on patch set 2 CR +1 V +1 04/12/26, 11:54
Deprecation-109551-GeneralUtilityGetIndpEnv.rst:40ReplyWith your argument I'm fine. Let's see if we can nudge people this way. -
Christian Kuhn voted on patch set 2 CR +2 V +2 04/12/26, 12:06
-
Christian Kuhn merged patch set 3 04/12/26, 12:07
Deprecation-109551-GeneralUtilityGetIndpEnv.rst:40