Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

93631[WIP][BUGFIX] sqlite add fields with dbtype comment

Stefan Bürk CR 0 V -1 Easy +5 −1 updated 04/13/26, 22:25

Commit message

-------------------------------------------------------------
@todo's

- [ ] Verify if issue is on our side (TYPO3) or upstream on
      doctrine/dbal's side:

      * https://github.com/sbuerk/doctrine-dbal/pull/1

- [ ] Find a solution to allow adding such fields with
      SQlite.

- [ ] Investigate if issue also occurs on TYPO3 13.4
      and 12.4.
-------------------------------------------------------------

Database analyzer failes to add fields with the requirement
of `dbtype` comments to a already existing table for `SQLite`
honored with database errors similar to:

  An exception occurred while executing a query:
  SQLSTATE[HY000]: General error: 1 error in table
  a_test_table after add column: incomplete input

`SchemaMigratorTest:.addNewColumns` is modified now trying
to add following field types:

- JSON field `a_test_table.configuration` defined
  in fixture `addColumnsToTable.sql` file.

- UUID field `a_test_table.lookupid` defined in
  fixture `addColumnsToTable.sql` file.

Same issue occures if fields are added through the
`DefaultTcaSchema` based on `TCA` configuration,
which can hit existing instances upgrading it to
TYPO3 v14 to fail.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/31/93631/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/31/93631/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Files 2

Review log 47

  1. Stefan Bürk uploaded patch set 1 04/11/26, 21:39

  2. Stefan Bürk uploaded patch set 2 04/11/26, 21:39

  3. core-ci voted on patch set 2 V -1 04/11/26, 21:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99992

  4. core-ci voted on patch set 1 V -1 04/11/26, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99991

  5. Stefan Bürk wrote 04/11/26, 22:49

    Topic set to doctrine/dbal
  6. Stefan Bürk updated the commit message in patch set 3 V -1 04/13/26, 22:11

  7. core-ci voted on patch set 3 V -1 04/13/26, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100108