Review main Merged

93632[BUGFIX] Fix queryParameters structure in RecordsXmlSitemapDataProvider

Benni Mack CR +2 V +2 Normal +113 −7 updated 04/12/26, 14:55

Commit message

The switch from string-based `additionalParams` to array-based
`queryParameters` in #109370 left `getUrlFieldParameterMap()` and
`getUrlAdditionalParams()` producing flat bracket-notation keys
(e.g. `tx_news[action]`) instead of nested PHP arrays. Previously
the `http_build_query()`/`parse_str()` roundtrip implicitly converted
these, but `queryParameters` passes arrays directly to the site
router where route enhancers expect nested structures.

The patch changes `getUrlFieldParameterMap()` to `parse_str()` to
convert bracket-notation keys like tx_news[id]=42 into a
properly nested array ['tx_news' => ['id' => '42']],
then merges via array_replace_recursive.

In the method `getUrlAdditionalParams()` the config from
TypoScript is already a nested
array (['tx_news' => ['action' => 'show']]), so instead of
flattening it to bracket keys, we now directly merge it
with `array_replace_recursive`.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Alexander Grein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Alexander Grein +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 04/12/26, 08:44

  2. core-ci voted on patch set 1 V +1 04/12/26, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100013

  3. Alexander Grein voted on patch set 1 CR +1 V +1 04/12/26, 11:15

  4. Oliver Klee voted on patch set 1 V +1 04/12/26, 12:58

  5. Georg Ringer voted on patch set 1 CR +2 V +2 04/12/26, 14:55

  6. Georg Ringer merged patch set 2 04/12/26, 14:55