Review main Merged

93634[BUGFIX] Allow sys_file_metadata fields in file list column selection

Benni Mack CR +2 V +2 Easy +3 −1 updated 04/12/26, 18:04

Commit message

Commit 4d0ac90fce3 introduced a TCA schema check in
`FileList::setColumnsToRender()` to prevent crashes when
`EXT:filemetadata` is not installed. However, the check only
validated fields against the `sys_file` schema, silently
filtering out metadata fields like `description` and
`alternative` which are defined in `sys_file_metadata`.

This caused the "Show columns" feature in the Media module
list view to display empty columns for all metadata fields,
even when `EXT:filemetadata` is installed.

The fix extends the check to also accept fields from the
`sys_file_metadata` schema when it is available.

Review

  • Code review CR +2 Done
    • Annett Jähnichen +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Annett Jähnichen +2
    • Benjamin Franzke +1

Issues 2

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 04/12/26, 17:28

  2. Annett Jähnichen commented on patch set 1 CR +1 V +1 04/12/26, 17:51

    Checked in Browser. Fields are already in list view.
  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 04/12/26, 17:57

  4. Annett Jähnichen voted on patch set 1 CR +2 V +2 04/12/26, 17:58

  5. Annett Jähnichen merged patch set 2 04/12/26, 17:58

  6. core-ci voted on patch set 1 V +1 04/12/26, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100030