Review main Merged

93637[BUGFIX] Add index for content_from_pid in pages table

Ravi Sachaniya CR +2 V +2 Easy +1 −0 updated 04/13/26, 11:30

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Ravi Sachaniya uploaded patch set 1 04/13/26, 10:33

  2. core-ci voted on patch set 1 V +1 04/13/26, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100067

  3. Oliver Klee voted on patch set 1 CR +1 04/13/26, 10:45

  4. Christian Kuhn commented on patch set 1 04/13/26, 10:47

    ext_tables.sql:46

    is the query in question the one fired by PageLayoutController->getPageLinksWhereContentIsAlsoShownOn() ?
  5. Ravi Sachaniya commented on patch set 1 04/13/26, 10:50

    ext_tables.sql:46 Reply

    yes the field `content_from_pid` is in the where cluase with `deleted` constraint in this method `\TYPO3\CMS\Backend\Controller\PageLayoutController::getPageLinksWhereContentIsAlsoShownOn`
  6. Christian Kuhn commented on patch set 1 CR +1 V +1 04/13/26, 11:05

    ext_tables.sql:46 Reply

    ok, so that's an index relevant for exactly one core db query. backend related, but the most prominent main module. i see no simple solution to avoid that query in code, either. i thought about a combined index, but the 'where content_from_pid=4711' most likely restricts the result set to a very small amount of pages already, further fiddling with the index is not worth it and/or would ignored by db then anyway. i'd be even fine with a v13 backport, but it wouldn't be strictly necessary since affected instances could easily add this index as custom ext_tables.sql. otoh, the change isn't risky and it only adds an index that instances *may* add, but don't *must*. as such, it is not problematic from v13 maintenance release point of view, and we've done similar things earlier already.
  7. Stefan Bürk voted on patch set 1 CR +1 V +1 04/13/26, 11:06

  8. Christian Kuhn voted on patch set 1 CR +2 V +2 04/13/26, 11:10

  9. Christian Kuhn merged patch set 2 04/13/26, 11:30