Review main Merged

93640[TASK] Avoid DataHandler FlexForm traverser in ext:import

Christian Kuhn CR +2 V +2 Normal +109 −97 updated 04/13/26, 15:35

Commit message

Import::setFlexFormRelations() and Import::processSoftReferences()
use the DataHandler FlexForm traversal infrastructure to walk
FlexForm value arrays: They instantiate a DataHandler, set its
callBackObj property to the Import instance, and call
checkValue_flex_procInData(). This is the same callback-dispatch
pattern we eliminated from FlexFormTools and ReferenceIndex with
issues #102212 and #102218 respectively.

The patch rewrites Import using custom methods with explicit
datastructure driven nested foreach loops over sheets, elements,
section containers and their fields - the same structure used by
cleanFlexFormXML() and getRelationsFromFlexData().

As a consequence, `@internal` DataHandler::$callBackObj has no
remaining external consumers and is removed. The four traverser
methods and their callbacks are protected.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 710

  1. Christian Kuhn uploaded patch set 1 04/13/26, 12:04

  2. core-ci voted on patch set 1 V +1 04/13/26, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100078

  3. Christian Kuhn updated the commit message in patch set 2 V +1 04/13/26, 13:07

  4. core-ci voted on patch set 2 V -1 04/13/26, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100081

  5. Christian Kuhn updated the commit message in patch set 3 V -1 04/13/26, 13:37

  6. core-ci voted on patch set 3 V +1 04/13/26, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100085

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 04/13/26, 14:35

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 04/13/26, 15:19

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 04/13/26, 15:35

  10. Christian Kuhn merged patch set 4 04/13/26, 15:35