93642[BUGFIX] Use field name as fallback in EXT:filelist if no label available
Commit message
Review
-
Code review CR +1
- Annett Jähnichen +1
-
Verified V +1
- Annett Jähnichen +1
- core-ci +1 CI
Issues 1
Files 2
Review log 79
-
Georg Ringer uploaded patch set 1 04/13/26, 13:33
-
Georg Ringer commented on patch set 1 04/13/26, 13:33
This change is ready for review. -
core-ci voted on patch set 1 V -1 04/13/26, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100084
-
core-ci voted on patch set 1 V +1 04/13/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100084
-
Annett Jähnichen commented on patch set 1 CR +1 V +1 04/14/26, 15:08
Tested this patch, solves the problem. -
Garvin Hicking commented on patch set 1 04/14/26, 15:17
FileListController.php:565Can't check atm but could we do a stricter check to '' / 0 / null / [] here? For exmaple witthout looking deeper I wouldn't know for which return this is falling back. And could a label hold "0"? This wouldn't be possible then. -
Sebastian Iffland commented on patch set 1 04/14/26, 15:35
FileListController.php:565Reply UnresolvedI agree. Original method has strict return type `string`, see https://github.com/TYPO3/typo3/blob/c8d64287bfc81a411dad2730927efbc63373f633/typo3/sysext/filelist/Classes/FileList.php#L1711. With current **not** check `0` would not be possible anymore. Why not just apply strict type checks here? `$label === ''` 🤔 -
Georg Ringer abandoned the change 04/15/26, 05:11
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/93668 -
Ayke Halder commented on patch set 1 04/15/26, 09:21
FileList.php:509UnresolvedMust be implemented in front of ̀isFieldSortable` if-clause.