Review main Abandoned

93642[BUGFIX] Use field name as fallback in EXT:filelist if no label available

Georg Ringer CR +1 V +1 Easy +6 −0 updated 04/15/26, 09:21

Commit message

Just as in the records module the file listing must use the field name as
fallback if no proper label is provided.

Review

  • Code review CR +1
    • Annett Jähnichen +1
  • Verified V +1
    • Annett Jähnichen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Georg Ringer uploaded patch set 1 04/13/26, 13:33

  2. Georg Ringer commented on patch set 1 04/13/26, 13:33

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 04/13/26, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100084

  4. core-ci voted on patch set 1 V +1 04/13/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100084

  5. Annett Jähnichen commented on patch set 1 CR +1 V +1 04/14/26, 15:08

    Tested this patch, solves the problem.
  6. Garvin Hicking commented on patch set 1 04/14/26, 15:17

    FileListController.php:565

    Can't check atm but could we do a stricter check to '' / 0 / null / [] here? For exmaple witthout looking deeper I wouldn't know for which return this is falling back. And could a label hold "0"? This wouldn't be possible then.
  7. Sebastian Iffland commented on patch set 1 04/14/26, 15:35

    FileListController.php:565 Reply Unresolved

    I agree. Original method has strict return type `string`, see https://github.com/TYPO3/typo3/blob/c8d64287bfc81a411dad2730927efbc63373f633/typo3/sysext/filelist/Classes/FileList.php#L1711. With current **not** check `0` would not be possible anymore. Why not just apply strict type checks here? `$label === ''` 🤔
  8. Georg Ringer abandoned the change 04/15/26, 05:11

  9. Ayke Halder commented on patch set 1 04/15/26, 09:21

    FileList.php:509 Unresolved

    Must be implemented in front of ̀isFieldSortable` if-clause.