Review main Merged

93643[TASK] Use DI in ext:core Configuration/Richtext

Christian Kuhn CR +2 V +2 Expert +742 −862 updated 04/13/26, 16:34

Commit message

The casual cycle:

Declare class readonly, use DI for its service dependencies,
change a consumer (DataHandler) to get service injected.

Turn remaining unit tests into functional tests and clean them up,
avoiding mocks where easily possible, this time using a
'prime caches' approach to shortcut a static dependency - not
great but not *that* fragile either in this case, probably.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 710

  1. Christian Kuhn uploaded patch set 1 04/13/26, 15:34

  2. core-ci voted on patch set 1 V -1 04/13/26, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100089

  3. Christian Kuhn uploaded patch set 2 V -1 04/13/26, 15:56

  4. core-ci voted on patch set 2 V +1 04/13/26, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100091

  5. Christian Kuhn updated the commit message in patch set 3 V +1 04/13/26, 16:10

  6. core-ci voted on patch set 3 V +1 04/13/26, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100092

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 04/13/26, 16:23

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 04/13/26, 16:29

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 04/13/26, 16:34

  10. Christian Kuhn merged patch set 4 04/13/26, 16:34