Review main Merged

93644[TASK] Update PHPStan to v2.1.47

Garvin Hicking CR +2 V +2 Easy +7 −13 updated 04/13/26, 16:57

Commit message

Updates PHPStan to the latest version 2.1.47.

New PHPStan version no longer reports one false
negatives, and one new irrelevant nullability
check.

Executed commands:

> Build/Scripts/runTests.sh -s composer -- \
      require --dev phpstan/phpstan:^2.1.47
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 810

  1. Garvin Hicking uploaded patch set 1 04/13/26, 16:21

  2. Garvin Hicking updated the commit message in patch set 2 04/13/26, 16:23

  3. Garvin Hicking commented on patch set 2 04/13/26, 16:30

    Please note: The 13.4 backport contains one addition to the baseline due to a new redundant "is_array" check. I'd rather not touch this place in v13, but feel free to resolve this differently.
  4. core-ci voted on patch set 2 V +1 04/13/26, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100094

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 04/13/26, 16:36

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 04/13/26, 16:38

  7. Oliver Klee voted on patch set 2 CR +1 V +1 04/13/26, 16:38

  8. Garvin Hicking voted on patch set 2 CR +2 V +2 04/13/26, 16:42

  9. Garvin Hicking merged patch set 3 04/13/26, 16:42

  10. core-ci voted on patch set 1 V +1 04/13/26, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100093