Review main Abandoned Breaking

93647[!!!][TASK] Remove redundant FAL DriverInterface methods

Benni Mack CR -1 V +1 Expert +525 −696 updated 10/15/26, 19:49

Commit message

This change removes 17 methods from DriverInterface that are
either trivially derivable, can be consolidated into simpler
Flysystem-aligned replacements, or are lifecycle-only concerns.

Removed without replacement (7):
- fileExistsInFolder(), folderExistsInFolder(), getFileInFolder(),
  getFolderInFolder(), countFilesInFolder(), countFoldersInFolder(),
  isFolderEmpty()

Removed in favor of new replacements (6):
- renameFile() + moveFileWithinStorage() -> new moveFile()
- renameFolder() + moveFolderWithinStorage() -> new moveFolder()
- copyFileWithinStorage() -> new copyFile()
- copyFolderWithinStorage() -> new copyFolder()

The four new methods take full source and target identifiers, aligning
the driver API closer to Flysystem conventions. They are added to
DriverInterface and implemented on AbstractDriver (throwing defaults for
third-party drivers) and LocalDriver.

Removed lifecycle methods (4):
- processConfiguration(), setStorageUid(), initialize(),
  mergeConfigurationCapabilities()

These are consolidated into initializeForStorage(), which is now part of
DriverInterface. StorageRepository calls it before constructing
ResourceStorage, so the ResourceStorage constructor no longer
initializes the driver itself.

Review

  • Code review CR -1
    • Garvin Hicking -1
    • Andreas Kienast -1
  • Verified V +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1525

  1. Benni Mack uploaded patch set 1 04/13/26, 17:06

  2. Benni Mack commented on patch set 2 04/13/26, 17:10

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 04/13/26, 17:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100100

  4. core-ci voted on patch set 2 V -1 04/13/26, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100101

  5. Benni Mack uploaded patch set 3 V -1 07/02/26, 11:31

  6. Benni Mack updated the commit message in patch set 4 07/02/26, 11:47

  7. Benni Mack marked it ready for review 07/02/26, 11:47

  8. core-ci voted on patch set 3 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104231

  9. core-ci voted on patch set 4 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104232

  10. core-ci commented on patch set 4 07/02/26, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104232

  11. core-ci voted on patch set 3 V -1 07/02/26, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104231

  12. Benni Mack rebased onto patch set 5 V -1 07/02/26, 15:33

  13. core-ci voted on patch set 5 V -1 07/02/26, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104239

  14. Benni Mack uploaded patch set 6 V -1 07/03/26, 06:51

  15. core-ci voted on patch set 6 V +1 07/03/26, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104265

  16. Benni Mack updated the commit message in patch set 7 V +1 07/03/26, 09:00

  17. Benni Mack marked it ready for review 07/03/26, 09:00

  18. core-ci voted on patch set 7 V +1 07/03/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104273

  19. Oliver Klee voted on patch set 7 V +1 07/03/26, 09:32

  20. Oliver Klee updated the commit message in patch set 8 V +1 07/03/26, 09:33

  21. Oliver Klee voted on patch set 8 V +1 07/03/26, 09:33

  22. core-ci voted on patch set 8 V +1 07/03/26, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104274

  23. Garvin Hicking commented on patch set 8 CR -1 07/03/26, 10:39

    I think we should add extension scanner entries for these usages
  24. Andreas Kienast commented on patch set 8 CR -1 07/03/26, 10:43

    DriverInterface.php:449 Unresolved

    I'm not fully convinced here, yet. If I have to implement a driver for an API-based storage, getting the element count via a dedicated API call may be cheaper than fetching a list of all files in that folder. Since we had two dedicated `count*InFolder` methods, implementing `\Countable` doesn't help here.
  25. Benni Mack abandoned the change 10/15/26, 19:49

    wont do this