93647[!!!][TASK] Remove redundant FAL DriverInterface methods
Commit message
Review
-
Code review CR -1
- Garvin Hicking -1
- Andreas Kienast -1
-
Verified V +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Resource/Driver/AbstractDriver.php+56 −0
- typo3/sysext/core/Classes/Resource/Driver/DriverInterface.php1+32 −129
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+106 −274
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+36 −52
- typo3/sysext/core/Classes/Resource/StorageRepository.php+22 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-109094-FALDriverInterfaceRedundantMethodsRemoved.rstnew+148 −0
- typo3/sysext/core/Tests/Functional/Resource/Driver/LocalDriverTest.php+47 −48
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+59 −18
- typo3/sysext/core/Tests/Functional/Resource/SynchronizeFolderRelationsTest.php+4 −0
- typo3/sysext/core/Tests/Unit/Resource/Driver/Fixtures/TestingDriver.php+15 −92
- typo3/sysext/core/Tests/Unit/Resource/Driver/Fixtures/TestingHierarchicalFilesystemDriver.php+0 −83
Review log 1525
-
Benni Mack uploaded patch set 1 04/13/26, 17:06
-
Benni Mack commented on patch set 2 04/13/26, 17:10
Published edit on patch set 1. -
core-ci voted on patch set 1 V -1 04/13/26, 17:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100100
-
core-ci voted on patch set 2 V -1 04/13/26, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100101
-
Benni Mack uploaded patch set 3
V -107/02/26, 11:31 -
Benni Mack updated the commit message in patch set 4 07/02/26, 11:47
-
Benni Mack marked it ready for review 07/02/26, 11:47
-
core-ci voted on patch set 3 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104231
-
core-ci voted on patch set 4 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104232
-
core-ci commented on patch set 4 07/02/26, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104232
-
core-ci voted on patch set 3 V -1 07/02/26, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104231
-
Benni Mack rebased onto patch set 5
V -107/02/26, 15:33 -
core-ci voted on patch set 5 V -1 07/02/26, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104239
-
Benni Mack uploaded patch set 6
V -107/03/26, 06:51 -
core-ci voted on patch set 6 V +1 07/03/26, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104265
-
Benni Mack updated the commit message in patch set 7
V +107/03/26, 09:00 -
Benni Mack marked it ready for review 07/03/26, 09:00
-
core-ci voted on patch set 7 V +1 07/03/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104273
-
Oliver Klee voted on patch set 7 V +1 07/03/26, 09:32
-
Oliver Klee updated the commit message in patch set 8
V +107/03/26, 09:33 -
Oliver Klee voted on patch set 8 V +1 07/03/26, 09:33
-
core-ci voted on patch set 8 V +1 07/03/26, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104274
-
Garvin Hicking commented on patch set 8 CR -1 07/03/26, 10:39
I think we should add extension scanner entries for these usages -
Andreas Kienast commented on patch set 8 CR -1 07/03/26, 10:43
DriverInterface.php:449UnresolvedI'm not fully convinced here, yet. If I have to implement a driver for an API-based storage, getting the element count via a dedicated API call may be cheaper than fetching a list of all files in that folder. Since we had two dedicated `count*InFolder` methods, implementing `\Countable` doesn't help here. -
Benni Mack abandoned the change 10/15/26, 19:49
wont do this