Review main Merged

93648[TASK] Dissolve DataHandler FlexForm traverser callback methods

Christian Kuhn CR +2 V +2 Hard +273 −249 updated 04/14/26, 10:17

Commit message

The DataHandler FlexForm save, copy and remap paths rely on a
string-named callback pattern: Three protected methods were
registered by name and invoked via the checkValue_flex_procInData() &
checkValue_flex_procInData_travDS() traversal pair. This mirrors the
FlexFormTools traverser removed in 2023 and is the last remaining
instance of that pattern in core.

The patch replaces this with explicit data structure driven
foreach loops. This on one hand repeats a similar traversal
pattern multiple times, but separates the code paths from
each other, which makes the logic much easier to grasp: We
avoid a recursive method combined with an opaque callback.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 04/13/26, 17:24

  2. core-ci voted on patch set 1 V +1 04/13/26, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100102

  3. Christian Kuhn updated the commit message in patch set 2 V +1 04/13/26, 17:45

  4. core-ci voted on patch set 2 V +1 04/13/26, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100103

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 04/13/26, 19:14

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 04/14/26, 09:49

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 04/14/26, 10:17

  8. Christian Kuhn merged patch set 3 04/14/26, 10:17