Review main Merged

93653[TASK] Declare more classes readonly in ext:core

Christian Kuhn CR +2 V +2 Normal +39 −39 updated 04/14/26, 10:15

Commit message

Targets:
* Static helper classes
* Internal classes that allow adding the keyword easily
* Leaf classes not meant to be extended

All in all, this list should be quite safe to do, even
at the end of v14 development. In case this heavily breaks
an extension that can't solve the issue with a more clean
approach, we could still omit the keyword if necessary.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 39

Show 19 more files

Review log 68

  1. Christian Kuhn uploaded patch set 1 04/14/26, 08:33

  2. core-ci voted on patch set 1 V -1 04/14/26, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100125

  3. Christian Kuhn uploaded patch set 2 V -1 04/14/26, 08:50

  4. core-ci voted on patch set 2 V +1 04/14/26, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100127

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 04/14/26, 09:52

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 04/14/26, 09:55

  7. Georg Ringer voted on patch set 2 CR +2 V +2 04/14/26, 10:15

  8. Georg Ringer merged patch set 3 04/14/26, 10:15