93654[TASK] Prepare ContentObjectRenderer for v15 refactoring
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 15
- typo3/sysext/core/Classes/Page/ContentAreaClosure.php+4 −2
- typo3/sysext/core/Classes/Page/ContentAreaCollection.php+17 −5
- typo3/sysext/core/Documentation/Changelog/14.3/Deprecation-109575-ContentObjectRendererPropertiesAndMethods.rst6new+170 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Render/RecordViewHelper.php+6 −12
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+5 −11
- typo3/sysext/frontend/Classes/Content/ContentAreaResolver.php+5 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php7+146 −128
- typo3/sysext/frontend/Classes/ContentObject/PageViewContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+2 −0
- typo3/sysext/frontend/Classes/DataProcessing/PageContentFetchingProcessor.php+1 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+10 −3
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+25 −0
- typo3/sysext/seo/Classes/XmlSitemap/AbstractXmlSitemapDataProvider.php+1 −0
Review log 2939
Show 814 earlier messages
-
Christian Kuhn uploaded patch set 1 04/14/26, 08:41
-
core-ci voted on patch set 1 V -1 04/14/26, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100126
-
Christian Kuhn uploaded patch set 2
V -104/14/26, 09:39 -
core-ci voted on patch set 2 V +1 04/14/26, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100128
-
Christian Kuhn uploaded patch set 3
V +104/14/26, 10:31 -
core-ci voted on patch set 3 V +1 04/14/26, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100138
-
Christian Kuhn uploaded patch set 4
V +104/14/26, 11:55 -
core-ci voted on patch set 4 V +1 04/14/26, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100154
-
Christian Kuhn commented on patch set 4 04/14/26, 15:47
mmmh. some details might be too invasive in v14, i'll relax them again. the main goal is to have some clean deprecations in v14 to have less breaking stuff in v15. the commit message will reflect that later. -
Christian Kuhn uploaded patch set 5
V +104/14/26, 17:29 -
Christian Kuhn uploaded patch set 6 04/14/26, 17:32
-
core-ci voted on patch set 6 V -1 04/14/26, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100183
-
Christian Kuhn uploaded patch set 7
V -104/14/26, 17:43 -
core-ci voted on patch set 7 V +1 04/14/26, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100185
-
core-ci voted on patch set 5 V -1 04/14/26, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100182
-
Nikita Hovratov commented on patch set 7 04/15/26, 08:58
ContentObjectRenderer.php:5128Can be string|false and the phpdoc comment then removed -
Christian Kuhn commented on patch set 7 04/15/26, 09:56
talked to Nikita: We'll set that to related, not resolves. -
Christian Kuhn commented on patch set 7 04/15/26, 12:59
Reply
DoneContentObjectRenderer.php:5128ReplyDone -
Christian Kuhn uploaded patch set 8
V +104/15/26, 12:59 -
core-ci voted on patch set 8 V +1 04/15/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100251
-
Oliver Klee commented on patch set 8 04/15/26, 13:29
ContentObjectRenderer.php:5128ReplyI think Nikita was referring to the native return type: ```suggestion protected function getFromCache(array $configuration): string|false ``` Then we could drop the `@return` PHPDoc type annotation. -
Christian Kuhn commented on patch set 8 04/15/26, 14:15
ContentObjectRenderer.php:5128Replyi kept the 'false on cache miss' note since i think its helpful. did i miss something? -
Oliver Klee commented on patch set 8 04/15/26, 14:22
ContentObjectRenderer.php:5128ReplySorry, I looked in the wrong place! -
Chris Müller commented on patch set 8 04/15/26, 14:42
Deprecation-109575-ContentObjectRendererPropertiesAndMethods.rst:76```suggestion :php:`\TYPO3\CMS\Core\Configuration\FlexForm\FlexFormTools::convertFlexFormContentToArray()` ``` FlexFormService has been merged in FlexFormTools with #107945.Deprecation-109575-ContentObjectRendererPropertiesAndMethods.rst:170```suggestion Replace with :php:`FlexFormTools::convertFlexFormContentToArray()` and ```Deprecation-109575-ContentObjectRendererPropertiesAndMethods.rst:180```suggestion $conf = $this->flexFormTools->convertFlexFormContentToArray($flexFormXml); ``` -
Christian Kuhn commented on patch set 8 04/15/26, 23:27
Deprecation-109575-ContentObjectRendererPropertiesAndMethods.rst:76ReplyFix applied. Thank you!Deprecation-109575-ContentObjectRendererPropertiesAndMethods.rst:170ReplyFix applied.Deprecation-109575-ContentObjectRendererPropertiesAndMethods.rst:180ReplyFix applied. -
Christian Kuhn commented on patch set 9
V +104/15/26, 23:27Published edit on patch set 8. -
core-ci voted on patch set 9 V +1 04/15/26, 23:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100275
-
Nikita Hovratov voted on patch set 9 CR +1 04/16/26, 07:44
-
Christian Kuhn commented on patch set 9 CR -1 04/16/26, 10:28
ContentObjectRenderer.php:299got feedback regarding this one: parentRecord can be pretty useful in sub content elements to act depending on it's parent. example: insert records element. parentrecord is similar to some other properties i did not deprecate since they carry important side,sub and in this case parent context. this is one of the areas that will have to see a better solution later. we'll keep parentRecord for now. -
Christian Kuhn uploaded patch set 10
CR +1V +104/16/26, 11:02 -
Christian Kuhn commented on patch set 10 04/16/26, 11:02
ContentObjectRenderer.php:299ReplyDone -
core-ci voted on patch set 10 V +1 04/16/26, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100307
-
Stefan Bürk voted on patch set 10 CR +1 V +1 04/16/26, 11:26
-
Nikita Hovratov voted on patch set 10 CR +1 04/16/26, 11:30
-
Anja Leichsenring voted on patch set 10 CR +1 V +1 04/16/26, 16:41
-
Christian Kuhn voted on patch set 10 CR +2 V +2 04/17/26, 13:04
-
Christian Kuhn merged patch set 11 04/17/26, 13:04
-
Lina Wolf commented on patch set 11 05/14/26, 07:40
Does it mean that the TypoScript gettext property [cObj](https://docs.typo3.org/permalink/t3tsref:data-type-gettext-cobj) is now deprecated? -
Lina Wolf commented on patch set 11 05/14/26, 07:44
Reply
Sorry, found it mentioned in the changelog entry below