93657[BUGFIX] Introduce `PackageSetup` to unify extension setup
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Nicole Hummel +1
- Benni Mack +1
-
Verified V +2 Done
- Helmut Hummel +2
- Oliver Klee +1
- Nicole Hummel +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- Build/phpstan/phpstan-baseline.neon+6 −6
- typo3/sysext/core/Classes/Command/SetupExtensionsCommand.php+10 −19
- typo3/sysext/core/Classes/Package/PackageActivationService.php+17 −70
- typo3/sysext/core/Classes/Package/PackageSetup.phpnew+86 −0
- typo3/sysext/core/Tests/Functional/Package/Event/PackageInitializationEventTest.php+4 −4
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+12 −3
- typo3/sysext/extensionmanager/Tests/Unit/Controller/ActionControllerTest.php+6 −2
Review log 2533
Show 58 earlier messages
-
Helmut Hummel uploaded patch set 1 04/14/26, 10:10
-
Helmut Hummel uploaded patch set 2 04/14/26, 10:36
-
core-ci voted on patch set 1 V -1 04/14/26, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100133
-
Helmut Hummel rebased onto patch set 3 04/14/26, 11:04
-
core-ci voted on patch set 2 V -1 04/14/26, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100139
-
core-ci voted on patch set 3 V -1 04/14/26, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100148
-
Helmut Hummel uploaded patch set 4
V -104/14/26, 12:45 -
Simon Schaufelberger commented on patch set 4 04/14/26, 12:49
I would call it a TASK
-
Helmut Hummel commented on patch set 4 04/14/26, 12:51
Reply
hm, it actually fixes a bug. -
core-ci voted on patch set 4 V +1 04/14/26, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100155
-
Simon Schaufelberger commented on patch set 4 04/14/26, 12:54
Reply
ok but that is not clear from the title. -
Helmut Hummel commented on patch set 4 04/14/26, 17:15
Reply
feel free to suggest a better title. I fixed the bug by doing what is mentioned in the title. -
Helmut Hummel updated the commit message in patch set 5
V +104/14/26, 17:16 -
core-ci voted on patch set 5 V +1 04/14/26, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100179
-
Benni Mack commented on patch set 5 CR +1 V +1 04/14/26, 20:46
SetupExtensionsService.php:16I would put this into TYPO3\CMS\Core\Core or TYPO3\CMS\Core\Package, but does not matter here. -
Helmut Hummel rebased onto patch set 6
CR +1V +104/14/26, 21:39 -
Helmut Hummel commented on patch set 6 04/14/26, 21:41
SetupExtensionsService.php:16Replyput it in Package and call it PackageSetupService? -
core-ci voted on patch set 6 V +1 04/14/26, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100205
-
Mathias Brodala commented on patch set 6 04/15/26, 04:51
"ExtensionSetupService" would be a better order of terms. Or even just "ExtensionSetup", no need to call it "service". -
Helmut Hummel commented on patch set 6 04/15/26, 05:10
Reply
I agree. I also like to skip the service suffix. However i'm typo3 there are more services with suffix than not -
Benni Mack commented on patch set 6 04/15/26, 05:41
SetupExtensionsService.php:16Replyyes. Or -- as discussed above just "Package\PackageSetup" then. -
Helmut Hummel uploaded patch set 7
V +104/15/26, 10:53 -
Helmut Hummel commented on patch set 7 04/15/26, 10:54
Reply
DoneReply
DoneSetupExtensionsService.php:16ReplyDone -
core-ci voted on patch set 7 V +1 04/15/26, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100245
-
Mathias Brodala commented on patch set 7 04/15/26, 11:10
"PackageSetup" class -
Oliver Klee updated the commit message in patch set 8
V +104/15/26, 12:17 -
Oliver Klee commented on patch set 8 04/15/26, 12:17
Reply
Done -
core-ci voted on patch set 8 V +1 04/15/26, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100249
-
Benni Mack voted on patch set 8 CR +1 V +1 04/15/26, 12:34
-
Oliver Klee voted on patch set 8 V +1 04/15/26, 14:06
-
Nicole Hummel voted on patch set 8 CR +1 V +1 04/16/26, 07:24
-
Helmut Hummel voted on patch set 8 CR +2 V +2 04/16/26, 07:25
-
Helmut Hummel merged patch set 9 04/16/26, 07:25