Review main Merged

93658[BUGFIX] Set up packages at the end of TYPO3 setup

Helmut Hummel CR +2 V +2 Hard +338 −215 updated 05/12/26, 09:38

Commit message

Instead of making `theme_camino` a factory default extension,
the selected distribution is now activated explicitly during setup
and extension setup is executed afterwards for all active extensions.

This avoids a dangling state where `theme_camino` could be active
even if its distribution was not selected, leaving its initialization
data unimported and potentially conflicting with another distribution
chosen during setup.

The setup process now reloads the container after activating a
distribution package and then runs extension setup for all active
packages. This ensures that extension-specific setup tasks such as
asset publication and distribution data import are executed reliably.

This also makes the setup process more robust in Composer mode,
where active extensions are expected to be set up during system setup
and an additional manual `extension:setup` call is no longer required.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 5096

Show 3771 earlier messages
  1. Helmut Hummel uploaded patch set 1 04/14/26, 10:10

  2. core-ci voted on patch set 1 V -1 04/14/26, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100134

  3. Helmut Hummel rebased onto patch set 2 V -1 04/14/26, 10:36

  4. core-ci voted on patch set 2 V -1 04/14/26, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100140

  5. Helmut Hummel uploaded patch set 3 V -1 04/14/26, 11:04

  6. core-ci voted on patch set 3 V -1 04/14/26, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100150

  7. Helmut Hummel rebased onto patch set 4 V -1 04/14/26, 12:52

  8. core-ci voted on patch set 4 V -1 04/14/26, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100157

  9. Helmut Hummel uploaded patch set 5 V -1 04/14/26, 13:15

  10. core-ci voted on patch set 5 V -1 04/14/26, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100163

  11. core-ci commented on patch set 5 04/14/26, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100163

  12. Helmut Hummel uploaded patch set 6 V -1 04/14/26, 17:13

  13. Helmut Hummel uploaded patch set 7 04/14/26, 17:18

  14. core-ci voted on patch set 6 V -1 04/14/26, 17:28 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 7 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100178

  15. core-ci voted on patch set 7 V -1 04/14/26, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100180

  16. core-ci commented on patch set 7 04/14/26, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100180

  17. Helmut Hummel uploaded patch set 8 V -1 04/14/26, 21:39

  18. core-ci voted on patch set 8 V +1 04/14/26, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100206

  19. Oliver Klee updated the commit message in patch set 9 V +1 04/15/26, 07:37

  20. core-ci voted on patch set 9 V +1 04/15/26, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100232

  21. Helmut Hummel uploaded patch set 10 V +1 04/15/26, 10:53

  22. core-ci voted on patch set 10 V +1 04/15/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100246

  23. Oliver Klee updated the commit message in patch set 11 V +1 04/15/26, 12:17

  24. core-ci voted on patch set 11 V +1 04/15/26, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100250

  25. Helmut Hummel uploaded patch set 12 V +1 04/16/26, 08:33

  26. Helmut Hummel uploaded patch set 13 04/16/26, 08:34

  27. core-ci voted on patch set 12 V -1 04/16/26, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100300

  28. core-ci voted on patch set 13 V -1 04/16/26, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100302

  29. core-ci voted on patch set 13 V +1 04/18/26, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100302

  30. Benni Mack commented on patch set 13 04/20/26, 08:10

    CommandLineUserCreation.php:27

    I suggest to mark the whole class internal
  31. Helmut Hummel uploaded patch set 14 V +1 04/20/26, 16:53

  32. core-ci voted on patch set 14 V +1 04/20/26, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100588

  33. Helmut Hummel commented on patch set 14 04/20/26, 17:29

    CommandLineUserCreation.php:27 Reply

    of course!
  34. André Buchmann commented on patch set 14 04/20/26, 22:12

    Works in composer and non-composer mode. The additional `extension:setup` is not needed anymore. Question for my understanding: In non-composer mode the selection of the distribution in the `typo3 setup` works perfectly. If I select none, there is only an empty site "main" created. In composer mode the distribution selection still asks for none/theme_camino, but always creates the site "camino". The difference is, that when I select "none", the empty site "main" is created additionally to the camino-site. To me the distribution question in the setup seems unnecessary in composer mode, as the composer.json defines which distributions are installed anyways. Is this behavior intended?
  35. Helmut Hummel commented on patch set 14 04/21/26, 10:46

    Reply

    very good point, thanks. seems like we can skip the question when a distribution package is already active. will add this to this change
  36. Benni Mack updated the commit message in patch set 15 V +1 04/22/26, 07:18

  37. core-ci voted on patch set 15 V +1 04/22/26, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100857

  38. Helmut Hummel uploaded patch set 16 V +1 04/26/26, 17:48

  39. core-ci voted on patch set 16 V -1 04/26/26, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101131

  40. Helmut Hummel uploaded patch set 17 V -1 04/26/26, 18:00

  41. core-ci voted on patch set 17 V -1 04/26/26, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101132

  42. core-ci commented on patch set 17 04/27/26, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101132

  43. Helmut Hummel rebased onto patch set 18 V -1 04/27/26, 07:36

  44. core-ci voted on patch set 18 V +1 04/27/26, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101149

  45. Helmut Hummel uploaded patch set 19 V +1 04/27/26, 08:44

  46. Helmut Hummel commented on patch set 19 04/27/26, 08:46

    Reply

    I fixed this now, by skipping any further questions about distributions in composer mode and only show which distributions are installed/ being configured in the web ui. For my understanding, this behaviour makes sense and is in line with other checks that are already performed
  47. Helmut Hummel updated the commit message in patch set 20 04/27/26, 08:46

  48. Helmut Hummel updated the commit message in patch set 21 04/27/26, 08:47

  49. core-ci voted on patch set 19 V +1 04/27/26, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101152

  50. core-ci voted on patch set 21 V +1 04/27/26, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101154

  51. core-ci voted on patch set 20 V +1 04/27/26, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101153

  52. Helmut Hummel uploaded patch set 22 V +1 04/27/26, 11:07

  53. core-ci voted on patch set 22 V +1 04/27/26, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101163

  54. Benjamin Franzke commented on patch set 22 V -1 04/27/26, 11:35

    Hey, with this change applied the CLI installation via `--distribution=theme_camino` fais for me. The script that I used for testing (yes we could/should add a similar acceptance test) is as follows: ``` rm -rf camino-testinstance/ mkdir camino-testinstance cd camino-testinstance ln -s ../typo3 ln -s ../index.php mkdir typo3conf/system/ -p # not needed for this demo, but helpful to access the backend when using the php development server cat > typo3conf/system/additional.php <<- EOF <?php \$GLOBALS['TYPO3_CONF_VARS']['BE']['entryPoint'] = 'admin'; EOF ./typo3/sysext/core/bin/typo3 setup \ --driver=sqlite \ --admin-username=admin \ --admin-user-password=$(openssl rand -base64 32) \ --distribution=theme_camino \ --server-type=other \ --force \ -n (sleep 1 && xdg-open http://127.0.0.1:8081/camino/) & php -S 127.0.0.1:8081 -t . -d max_execution_time=240 -d max_input_vars=1500 ``` Results in a 500 server error: ``` 500 Internal Server Error An error occurred while processing your request. Please try again later. Reason: Site camino depends on unavailable sets: typo3/theme-camino ```
  55. Helmut Hummel uploaded patch set 23 V +1 04/28/26, 11:03

  56. core-ci voted on patch set 23 V +1 04/28/26, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101211

  57. Helmut Hummel uploaded patch set 24 V +1 04/28/26, 11:16

  58. Helmut Hummel commented on patch set 22 04/28/26, 11:19

    Reply

    reason was, that on CLI, even with existing PackageStates.php file, the FailsafePackageManager considered itself in failsafe mode. This is now fixed by setting this to false, once recreatePackageStatesFileIfMissing is called. webui has no issue with that since the installations works across multiple requests, which receive new instances of PackageManager. good catch thanks. don't know how I missed that (except by mostly testing the web ui)
  59. core-ci voted on patch set 24 V +1 04/28/26, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101212

  60. Benjamin Franzke commented on patch set 24 04/30/26, 06:39

    Reply

    thx, works now 👍
  61. Oliver Klee updated the commit message in patch set 25 V +1 05/03/26, 08:28

  62. core-ci voted on patch set 25 V -1 05/03/26, 08:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101430

  63. core-ci commented on patch set 25 05/03/26, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101430

  64. core-ci voted on patch set 25 V +1 05/03/26, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101430

  65. Helmut Hummel uploaded patch set 26 V +1 05/05/26, 07:01

  66. core-ci voted on patch set 26 V -1 05/05/26, 07:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101525

  67. Oliver Klee updated the commit message in patch set 27 V -1 05/05/26, 07:15

  68. core-ci voted on patch set 27 V -1 05/05/26, 07:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101526

  69. Helmut Hummel uploaded patch set 28 V -1 05/05/26, 07:57

  70. core-ci voted on patch set 28 V +1 05/05/26, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101532

  71. Helmut Hummel uploaded patch set 29 V +1 05/05/26, 12:32

  1. core-ci voted on patch set 29 V +1 05/05/26, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101553

  2. Helmut Hummel uploaded patch set 30 V +1 05/06/26, 11:35

  3. core-ci voted on patch set 30 V -1 05/06/26, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101613

  4. Christian Kuhn uploaded patch set 31 05/06/26, 13:32

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  5. core-ci voted on patch set 30 V -1 05/06/26, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101613

  6. core-ci voted on patch set 31 V -1 05/06/26, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101617

  7. core-ci commented on patch set 31 05/06/26, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101617

  8. Helmut Hummel uploaded patch set 32 V -1 05/06/26, 18:13

  9. core-ci voted on patch set 32 V +1 05/06/26, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101633

  10. Helmut Hummel uploaded patch set 33 V +1 05/07/26, 10:38

  11. core-ci voted on patch set 33 V -1 05/07/26, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101670

  12. Helmut Hummel uploaded patch set 34 V -1 05/07/26, 13:47

  13. core-ci voted on patch set 34 V -1 05/07/26, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101691

  14. core-ci voted on patch set 34 V +1 05/07/26, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101691

  15. Benni Mack voted on patch set 34 CR +1 V +1 05/09/26, 11:38

  16. Helmut Hummel uploaded patch set 35 CR +1 V +1 05/11/26, 07:38

  17. core-ci voted on patch set 35 V -1 05/11/26, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101805

  18. core-ci commented on patch set 35 05/11/26, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101805

  19. Helmut Hummel uploaded patch set 36 V -1 05/11/26, 09:09

  20. core-ci voted on patch set 36 V +1 05/11/26, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101807

  21. Benni Mack voted on patch set 36 CR +1 V +1 05/11/26, 14:25

  22. Georg Ringer voted on patch set 36 CR +1 V +1 05/11/26, 19:01

  23. Georg Ringer voted on patch set 36 CR +2 V +2 05/11/26, 19:02

  24. Georg Ringer merged patch set 37 05/11/26, 19:09

  25. Helmut Hummel commented on patch set 37 05/12/26, 09:38

    Thank you very much for merging this for todays release!