Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
93670[WIP][TASK] Remove `GetColumnDeclarationSQLCommentTypeAwareTrait`
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/70/93670/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/70/93670/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Markus Klein +1
-
Verified V +1 Needs a vote
- Markus Klein +1
- core-ci +1 CI
Relation chain 2
- main 93673[WIP][TASK] add doctrine/dbal required bugfix
-
93670 [WIP][TASK] Remove `GetColumnDeclarationSQLCommentTypeAwareTrait` This change
Files 15
- typo3/sysext/core/Classes/Database/Driver/CustomPlatformDriverDecorator.php+0 −3
- typo3/sysext/core/Classes/Database/Platform/Traits/GetColumnDeclarationSQLCommentTypeAwareTrait.phpdeleted+0 −133
- typo3/sysext/core/Classes/Database/Platform/MariaDB1010Platform.php+0 −2
- typo3/sysext/core/Classes/Database/Platform/MariaDB1052Platform.php+0 −2
- typo3/sysext/core/Classes/Database/Platform/MariaDB1060Platform.php+0 −2
- typo3/sysext/core/Classes/Database/Platform/MariaDBPlatform.php+0 −2
- typo3/sysext/core/Classes/Database/Platform/MySQL80Platform.php+0 −2
- typo3/sysext/core/Classes/Database/Platform/MySQL84Platform.php+0 −2
- typo3/sysext/core/Classes/Database/Platform/MySQLPlatform.php+0 −2
- typo3/sysext/core/Classes/Database/Platform/PostgreSQLPlatform.phpdeleted+0 −35
- typo3/sysext/core/Classes/Database/Platform/SQLitePlatform.php+1 −5
- typo3/sysext/core/Classes/Database/Schema/SchemaManager/ColumnTypeCommentMethodsTrait.php+1 −21
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php9+58 −0
- typo3/sysext/core/Tests/Unit/Database/Mocks/MockPlatform/MockPostgreSQLPlatform.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Platform/PlatformHelperTest.php+0 −2
Review log 811
-
Stefan Bürk uploaded patch set 1 04/14/26, 17:40
-
Stefan Bürk wrote 04/14/26, 17:40
Topic set to database-analyzer -
Stefan Bürk updated the commit message in patch set 2 04/14/26, 17:44
-
Stefan Bürk updated the commit message in patch set 3 04/14/26, 17:45
-
core-ci voted on patch set 2 V +1 04/14/26, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100186
-
core-ci voted on patch set 1 V +1 04/14/26, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100184
-
core-ci voted on patch set 3 V +1 04/14/26, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100187
-
Markus Klein commented on patch set 3 04/14/26, 21:40
ConnectionMigrator.php:1645I think we can inline this short function in the even shorter function aboveConnectionMigrator.php:2183named args? not allowed right? is this a valid pattern? shouldn't the regex have some wrapper like '#'?ConnectionMigrator.php:2187I'd prefer `$replaced === null`, if doable -
Stefan Bürk commented on patch set 3 04/16/26, 12:53
ConnectionMigrator.php:1645ReplyI guess that is okay. Left over, in first iteration I needed that check also in other places and the reason why it existed. Having only the usage in the method above that should be fine to inline. Checking it again when working on the change again.ConnectionMigrator.php:2183Reply> named args? not allowed right? preg_replace() is one of the explicitly mentioned excemptions from the not use named arguments, see: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/PhpArchitecture/NamedArguments.html#leveraging-named-arguments-when-invoking-php-functions > Another instance arises with complex functions like preg_replace(), where developers often overlook argument positions and names: > is this a valid pattern? shouldn't the regex have some wrapper like '#'? Sure. And it literally works. TBH that pattern is copied over from doctrine which used that for years before dropping the "comment type hints" with Doctrine DBAL 4 and I never wanted to mangele around with it. Fine for you ?ConnectionMigrator.php:2187Reply`preg_replace(): array|string|null` The native return type allows also an array, which should not happen and was the reson to use the `is_string()` check a) for phpstan (possible, not checked) and b) to avoid type errors in case a array is returned and tried to pass to `trim()` which enforces native type string as argument and the reason why I would keep that for now. Fine for you ? -
Markus Klein commented on patch set 3 04/16/26, 13:58
ConnectionMigrator.php:1645ReplyDoneConnectionMigrator.php:2183ReplyFunny. sure keep as is.ConnectionMigrator.php:2187ReplyI'm aware of the possible array type, but this cannot happen; that's why I was asking. But no hard feelings. keep. -
Markus Klein voted on patch set 3 CR +1 V +1 04/16/26, 14:11