Review main Merged

93674[TASK] Avoid LoggerAwareTrait with final classes

Christian Kuhn CR +2 V +2 Normal +69 −88 updated 04/17/26, 13:00

Commit message

Stateless services are an important asset in modern PHP
programming: They indicate services being 'mostly harmless'
from architectural point of view.

LoggerAwareInterface with LoggerAwareTrait is unfortunate
in this regard: They prevent declaring otherwise stateless
services readonly on class level. TYPO3 core development
thus strives to slowly phase out LoggerAwareInterface.

The patch avoids LoggerAwareInterface in a couple of final
classes: These are safe to change without impact.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1115

  1. Christian Kuhn uploaded patch set 1 04/14/26, 19:53

  2. core-ci voted on patch set 1 V +1 04/14/26, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100199

  3. Christian Kuhn voted on patch set 1 CR -1 04/15/26, 12:56

  4. Christian Kuhn commented on patch set 1 04/15/26, 13:01

    RecordBreadcrumbProvider.php:45

    well, those readonly are obsolete with the class being declared readonly ...
  5. Christian Kuhn commented on patch set 1 04/15/26, 19:46

    RecordBreadcrumbProvider.php:45 Reply

    Done
  6. Christian Kuhn uploaded patch set 2 CR -1 V +1 04/15/26, 19:46

  7. core-ci voted on patch set 2 V -1 04/15/26, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100272

  8. core-ci commented on patch set 2 04/16/26, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100272

  9. Christian Kuhn rebased onto patch set 3 V -1 04/16/26, 11:36

  10. core-ci voted on patch set 3 V +1 04/16/26, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100313

  11. Benjamin Franzke voted on patch set 3 CR +1 V +1 04/16/26, 11:51

  12. Anja Leichsenring voted on patch set 3 CR +1 V +1 04/17/26, 09:16

  13. Oliver Klee voted on patch set 3 CR +1 V +1 04/17/26, 09:19

  14. Christian Kuhn voted on patch set 3 CR +2 V +2 04/17/26, 13:00

  15. Christian Kuhn merged patch set 4 04/17/26, 13:00