Review main Merged

93678[BUGFIX] Prevent Exception in StandardContentPreview Processor

Andreas Häfner CR +2 V +2 Easy +4 −0 updated 04/17/26, 06:08

Commit message

Rendering of preview fields like header and subheader need
TCA-configuration to determine Text-type. If there is no TCA for a
record, an UndefinedSchemaException is thrown.
StandardContentPreviewRenderer::renderPageModulePreviewHeader() now
returns early empty header, if no TCA is available to allow regular
'invalid value'-rendering.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Andreas Häfner +1
    • Ravi Sachaniya +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Andreas Häfner +1
    • Ravi Sachaniya +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1620

  1. Andreas Häfner uploaded patch set 1 04/15/26, 11:17

  2. core-ci voted on patch set 1 V +1 04/15/26, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100247

  3. Ravi Sachaniya commented on patch set 1 CR -1 04/15/26, 11:36

    StandardContentPreviewRenderer.php:92

  4. Andreas Häfner uploaded patch set 2 CR -1 V +1 04/16/26, 06:27

  5. Ravi Sachaniya commented on patch set 2 04/16/26, 06:31

    StandardContentPreviewRenderer.php:101

    This condition will be redundant now, right?
  6. Andreas Häfner commented on patch set 1 04/16/26, 06:35

    I recognized the error only for tt_content-Ctype like "tt_content.mask_linkbox". So TCA for table exists, but not for CType. Is it possible, that a record without table-TCA gets so far? I put the TCA-chek before schema variable. Is that what you meant?

    StandardContentPreviewRenderer.php:92 Reply

    Done
  7. core-ci voted on patch set 2 V -1 04/16/26, 06:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100293

  8. Andreas Häfner uploaded patch set 3 V -1 04/16/26, 06:38

  9. core-ci voted on patch set 3 V +1 04/16/26, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100294

  10. Andreas Häfner commented on patch set 3 04/16/26, 06:50

    Thank you. My fault. Fixed

    StandardContentPreviewRenderer.php:101 Reply

    Acknowledged
  11. Garvin Hicking updated the commit message in patch set 4 V +1 04/16/26, 09:11

  12. Garvin Hicking voted on patch set 4 CR +1 V +1 04/16/26, 09:11

  13. core-ci voted on patch set 4 V +1 04/16/26, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100306

  14. Ravi Sachaniya voted on patch set 4 CR +1 V +1 04/16/26, 10:02

  15. Oliver Klee voted on patch set 4 CR +1 04/16/26, 10:52

  16. Andreas Häfner voted on patch set 4 CR +1 V +1 04/17/26, 05:53

  17. Georg Ringer voted on patch set 4 CR +1 V +1 04/17/26, 06:06

  18. Benni Mack voted on patch set 4 CR +1 V +1 04/17/26, 06:07

  19. Georg Ringer voted on patch set 4 CR +2 V +2 04/17/26, 06:08

  20. Georg Ringer merged patch set 5 04/17/26, 06:08