Review main Merged

93680[BUGFIX] Prevent error when opening record history from log module

Oliver Hader CR +2 V +2 Easy +3 −1 updated 04/16/26, 12:55

Commit message

Issue #95910 added the language switcher to the record history view
but unconditionally passes $element to addLanguageSwitcher(). When
the history is accessed via the backend log module there is no page
or element context, so $element is null, which causes a fatal error.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1114

  1. Oliver Hader uploaded patch set 1 04/15/26, 14:58

  2. Oliver Klee voted on patch set 1 CR +1 04/15/26, 15:00

  3. Oliver Hader updated the commit message in patch set 2 CR +1 04/15/26, 15:11

  4. Oliver Hader commented on patch set 2 04/15/26, 15:11

    Thx for the quick vote. I just modified the commit message to provide some more context.
  5. Oliver Klee voted on patch set 2 CR +1 04/15/26, 15:13

  6. core-ci voted on patch set 1 V +1 04/15/26, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100257

  7. core-ci voted on patch set 2 V +1 04/15/26, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100261

  8. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 04/15/26, 20:26

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 04/15/26, 20:27

  10. Oliver Klee voted on patch set 3 CR +1 04/15/26, 20:30

  11. core-ci voted on patch set 3 V +1 04/15/26, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100273

  12. Josua Vogel voted on patch set 3 CR +1 V +1 04/16/26, 06:24

  13. Oliver Hader voted on patch set 3 CR +2 V +2 04/16/26, 12:55

  14. Oliver Hader merged patch set 4 04/16/26, 12:55