Review main Merged

93681[BUGFIX] Streamline returnUrl handling in PageLayoutController

Oliver Hader CR +2 V +2 Easy +1 −1 updated 04/17/26, 12:55

Commit message

A flaw with returnUrl in the PageLayoutController has been reported
to us by Hamed Kohi (0xHamy). However, potential security implications
are mitigated by Content-Security-Policy headers already.
That's why this flaw is addressed in public.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1217

  1. Oliver Hader uploaded patch set 1 04/15/26, 15:32

  2. core-ci voted on patch set 1 V -1 04/15/26, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100263

  3. core-ci commented on patch set 1 04/15/26, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100263

  4. Oliver Hader marked it work in progress 04/16/26, 07:00

  5. core-ci commented on patch set 1 04/16/26, 07:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100263

  6. Oliver Hader rebased onto patch set 2 V -1 04/16/26, 08:21

  7. core-ci voted on patch set 2 V +1 04/16/26, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100297

  8. Garvin Hicking commented on patch set 2 CR +1 V +1 04/16/26, 09:12

    Sorry, voted on the 13.4 backport instead of here. All good for me, could not find other occurences!
  9. Oliver Hader commented on patch set 2 04/16/26, 12:54

    This change is ready for review.
  10. Christian Kuhn commented on patch set 2 CR -1 04/16/26, 13:03

    +1. aware since i had a look at sanitizeLocalUrl() recently.

    PageLayoutController.php:422

    this needs $request since #109544
  11. Oliver Hader uploaded patch set 3 CR +1 V +1 04/16/26, 20:25

  12. Oliver Hader commented on patch set 3 04/16/26, 20:28

    PageLayoutController.php:422 Reply

    Done
  13. core-ci voted on patch set 3 V +1 04/16/26, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100346

  14. Garvin Hicking voted on patch set 3 CR +1 V +1 04/17/26, 05:08

  15. Christian Kuhn voted on patch set 3 CR +1 V +1 04/17/26, 12:50

  16. Oliver Hader voted on patch set 3 CR +2 V +2 04/17/26, 12:55

  17. Oliver Hader merged patch set 4 04/17/26, 12:55