Review main Merged

93685[TASK] Add site set settings for EXT:form template paths

Josua Vogel CR +2 V +2 Normal +219 −22 updated 04/20/26, 20:18

Commit message

The form framework now supports site set settings to override
Fluid template, partial, layout paths and translation files.

New settings provided by the typo3/form site set:
- form.templates.templateRootPath
- form.templates.partialRootPath
- form.templates.layoutRootPath
- form.translation.translationFile

These settings are applied in two ways:
1. As TypoScript constants in plugin.tx_form.view (index 10),
   controlling the Extbase plugin view paths.
2. Directly in ConfigurationManager::applySiteSettingsOverrides()
   which reads the site settings from the current request and
   merges them at key 20 into the YAML prototype configuration
   (renderingOptions).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 2027

Show 2 earlier messages
  1. Josua Vogel uploaded patch set 1 04/15/26, 18:49

  2. Josua Vogel uploaded patch set 2 04/15/26, 18:51

  1. core-ci voted on patch set 1 V +1 04/15/26, 19:00 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100270

  2. core-ci voted on patch set 2 V +1 04/15/26, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100271

  3. Josua Vogel uploaded patch set 3 V +1 04/16/26, 08:28

  4. Josua Vogel uploaded patch set 4 04/16/26, 08:30

  5. Josua Vogel commented on patch set 4 04/16/26, 08:37

  6. core-ci voted on patch set 3 V +1 04/16/26, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100298

  7. core-ci voted on patch set 4 V +1 04/16/26, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100299

  8. André Buchmann commented on patch set 4 04/19/26, 19:16

    Reply

    I also like this solution better

    Feature-109412-FormYamlAutoDiscovery.rst:200

    Use map style instead of tree in example (see https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.4.x/Important-106894-SiteSettingsyamlIsNowStoredAsAMap.html#important-106894-1750144877) form.templates.templateRootPath: EXT:my_sitepackage/Resources/Private/Templates/Form/Frontend/ form.templates.partialRootPath: EXT:my_sitepackage/Resources/Private/Partials/Form/Frontend/ form.templates.layoutRootPath: EXT:my_sitepackage/Resources/Private/Layouts/Form/Frontend/ translationFile: EXT:my_sitepackage/Resources/Private/Language/Form/locallang.xlf
  9. Josua Vogel uploaded patch set 5 V +1 04/20/26, 06:25

  10. core-ci voted on patch set 5 V +1 04/20/26, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100507

  11. Josua Vogel commented on patch set 5 04/20/26, 06:47

    Feature-109412-FormYamlAutoDiscovery.rst:200 Reply

    Done, thx for the hint!
  12. Benni Mack voted on patch set 5 CR +1 V +1 04/20/26, 12:38

  13. Garvin Hicking commented on patch set 5 04/20/26, 12:51

    What happens to integrators who have set the `10` TypoScript key or the YAML `20` key themselves already? Is this a breaking change for them / their extensions?
  14. Josua Vogel commented on patch set 6 CR +1 V +1 04/20/26, 12:52

    Published edit on patch set 5.
  15. Josua Vogel commented on patch set 6 04/20/26, 12:55

    Reply

    Nothing will happen until you set the settings
  16. core-ci voted on patch set 6 V +1 04/20/26, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100559

  17. Garvin Hicking commented on patch set 6 CR +1 V +1 04/20/26, 15:48

    Reply

    Acknowledged
  18. Stefan Froemken commented on patch set 6 04/20/26, 17:11

    Feature-109412-FormYamlAutoDiscovery.rst:161

    ```suggestion ------------------------------------ ```
  19. Josua Vogel commented on patch set 7 CR +1 V +1 04/20/26, 17:52

    Published edit on patch set 6.
  20. Garvin Hicking voted on patch set 7 CR +1 V +1 04/20/26, 17:57

  21. core-ci voted on patch set 7 V +1 04/20/26, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100595

  22. Benni Mack voted on patch set 7 CR +2 V +2 04/20/26, 18:41

  23. Benni Mack merged patch set 8 04/20/26, 18:41

  24. Benni Mack commented on patch set 8 04/20/26, 18:41

    Feature-109412-FormYamlAutoDiscovery.rst:161 Reply

    ah, crap. just saw your comment. Need to clean this up later-on!
  25. Josua Vogel commented on patch set 8 04/20/26, 20:18

    Feature-109412-FormYamlAutoDiscovery.rst:161 Reply

    No, I applied the fix. Just forgot to mention this