93688[BUGFIX] Dispatch `AfterPackageActivationEvent` on package activation again
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Stefan Froemken +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 2
Files 11
- typo3/sysext/core/Classes/Package/Event/PackageInitializationEvent.php2+12 −0
- typo3/sysext/core/Classes/Package/PackageActivationService.php+1 −1
- typo3/sysext/core/Classes/Package/PackageSetup.php2+3 −2
- typo3/sysext/core/Tests/Functional/Package/Event/PackageInitializationEventTest.php+2 −6
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Initialization/DispatchAfterPackageActivationEventOnPackageInitialization.php3+6 −8
- typo3/sysext/extensionmanager/Tests/Functional/Fixtures/Extensions/test_install_package_activation/Classes/Fixture.phpnew+30 −0
- typo3/sysext/extensionmanager/Tests/Functional/Fixtures/Extensions/test_install_package_activation/Configuration/Services.yamlnew+8 −0
- typo3/sysext/extensionmanager/Tests/Functional/Fixtures/Extensions/test_install_package_activation/composer.jsonnew+23 −0
- typo3/sysext/extensionmanager/Tests/Functional/Utility/InstallUtilityTest.phpnew+43 −0
- composer.json+1 −0
Review log 2839
Show 814 earlier messages
-
Helmut Hummel uploaded patch set 1 04/16/26, 11:32
-
Helmut Hummel updated the commit message in patch set 2 04/16/26, 11:33
-
core-ci voted on patch set 1 V -1 04/16/26, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100310
-
core-ci voted on patch set 2 V -1 04/16/26, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100311
-
Helmut Hummel rebased onto patch set 3
V -104/17/26, 13:13 -
Helmut Hummel uploaded patch set 4 04/17/26, 13:18
-
core-ci voted on patch set 3 V -1 04/17/26, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100383
-
core-ci voted on patch set 4 V -1 04/17/26, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100385
-
Christian Kuhn uploaded patch set 5
V -104/17/26, 15:45 -
Oliver Klee updated the commit message in patch set 6 04/17/26, 15:46
-
Oliver Klee voted on patch set 6 CR +1 04/17/26, 15:47
-
core-ci voted on patch set 5 V +1 04/17/26, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100396
-
core-ci voted on patch set 6 V +1 04/17/26, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100397
-
Christian Kuhn commented on patch set 6 04/17/26, 16:01
-
Helmut Hummel uploaded patch set 7
CR +1V +104/17/26, 18:03 -
Helmut Hummel uploaded patch set 8 04/17/26, 18:05
-
core-ci voted on patch set 7 V -1 04/17/26, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100408
-
core-ci voted on patch set 8 V +1 04/17/26, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100411
-
Helmut Hummel uploaded patch set 9
V +104/20/26, 07:13 -
Helmut Hummel commented on patch set 9 04/20/26, 07:14
PackageInitializationEvent.php:51Replypostponed the deprecation as it is less important than the actual fix -
core-ci voted on patch set 9 V -1 04/20/26, 07:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100517
-
Benjamin Kott commented on patch set 9 04/20/26, 09:52
did not see this patch, until it showed merge conflicts, just wanted to provide a quick fix and test for the issue, pick what you like best 93744: [BUGFIX] Dump class loading information on extension install | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93744 -
Helmut Hummel commented on patch set 9 04/20/26, 10:13
Reply
Thanks will pick up your tests, but go with my implementation, as it goes a bit beyond the actual fix -
Helmut Hummel commented on patch set 9 04/20/26, 10:17
Reply
Actually, I will skip your test, but add a different one, as yours tests a lot of implementation details -
Helmut Hummel uploaded patch set 10
V -104/20/26, 10:47 -
core-ci voted on patch set 10 V +1 04/20/26, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100545
-
Oliver Klee voted on patch set 10 V +1 04/20/26, 11:02
-
Benni Mack voted on patch set 10 CR +1 V +1 04/20/26, 12:21
-
Christian Kuhn commented on patch set 10 04/20/26, 12:53
DispatchAfterPackageActivationEventOnPackageInitialization.php:32nit. -
Helmut Hummel commented on patch set 10 04/20/26, 13:15
DispatchAfterPackageActivationEventOnPackageInitialization.php:32Replydarn... -
Helmut Hummel commented on patch set 10 04/20/26, 13:15
DispatchAfterPackageActivationEventOnPackageInitialization.php:32ReplyDone -
Helmut Hummel uploaded patch set 11
CR +1V +104/20/26, 13:16 -
core-ci voted on patch set 11 V +1 04/20/26, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100565
-
Oliver Klee voted on patch set 11 V +1 04/20/26, 13:33
-
Stefan Bürk voted on patch set 11 V +1 04/20/26, 17:31
-
Stefan Bürk voted on patch set 11 CR +1 04/20/26, 17:33
-
Stefan Froemken commented on patch set 11 CR +1 V +1 04/20/26, 17:36
Thank you Helmut. IMO a patch which definitely was to become part of the release tomorrow. I had that problem this morning and Core told me to create an issue at news. But I wondered, because I could not install any extension with PHP classes. I just stumbled over your patch and installing extensions is possible again. Nice. +1 and validated.PackageSetup.php:54Nice to have: Multiline -
Stefan Bürk commented on patch set 11 CR +2 V +2 04/20/26, 18:10
PackageSetup.php:54ReplyLet's do that as a follow-up. -
Stefan Bürk merged patch set 12 04/20/26, 18:10
PackageInitializationEvent.php:51