Review main Abandoned

93694[POC] Showcase Extbase AbstractDomainObject internal methods

Garvin Hicking CR 0 V 0 Normal +250 −0 updated 04/16/26, 17:30

Commit message

Run with:

```
./Build/Scripts/runTests.sh -s composerInstall && \
  ./Build/Scripts/runTests.sh -s phpstanMax
```

See:

```
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%  1 sec

 ------ --------------------------------------------------------------------------------------------------------------------------------------
  Line   Controller/BlogController.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------
  38     Call to method getUid() of internal class TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject from outside its root namespace TYPO3.
         🪪  method.internalClass
 ------ --------------------------------------------------------------------------------------------------------------------------------------

 [ERROR] Found 1 error
```

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 12

Review log 59

  1. Garvin Hicking uploaded patch set 1 04/16/26, 15:24

  2. Garvin Hicking updated the commit message in patch set 2 04/16/26, 15:25

  3. core-ci voted on patch set 2 V -1 04/16/26, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100336

  4. core-ci voted on patch set 1 V -1 04/16/26, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100335

  5. Garvin Hicking uploaded patch set 3 V -1 04/16/26, 16:14

  6. core-ci voted on patch set 3 V -1 04/16/26, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100338

  7. Garvin Hicking uploaded patch set 4 V -1 04/16/26, 16:47

  8. core-ci voted on patch set 4 V +1 04/16/26, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100341

  9. Garvin Hicking abandoned the change 04/16/26, 17:30