Review 13.4 Merged

93695[BUGFIX] Mitigate DI issues during database compare

Stefan Bürk CR +2 V +2 Easy +18 −15 updated 04/16/26, 16:34

Commit message

Patch #106867 changed the database restrictions to avoid
direct $GLOBALS['TCA]' access by switching to TcaSchema.
The patch already had to work around ext:install related
DI woes.

This patch adapts another detail: The query fired by
ConnectionMigrator that looks for table options (collation,
charset, ...) is run early without DI fully set up. The
patch #109437 worked on that already by re-using a
RestrictionContainer based workaround. This is not
sufficient with custom query restrictions.

The patch reverts the solution from #109437, and rewrites
the specific table options query to use the low level
doctrine QueryBuilder directly, circumventing all normal
TYPO3 logic on top. This is a pragmatic and stable approach
to the problem in this case since TYPO3 higher level logic
never deals with schema details.

Note issue #100807 has been reported a while ago for older
core majors already, it is only just now that the issue
becomes more promintent due to the v14 works. Nevertheless,
we'll aim for a v13 backport, since it is the same solution
in just a slightly different context, and mitigates the
issue quite effectively.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 4

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 04/16/26, 16:01

  2. core-ci voted on patch set 1 V +1 04/16/26, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100337

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 04/16/26, 16:34

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 04/16/26, 16:34

  5. Stefan Bürk merged patch set 2 04/16/26, 16:34