Review main Merged

93697[DOCS] Fix v14.2 changelog entries

Lina Wolf CR +2 V +2 Nightmare +3240 −2905 updated 04/21/26, 09:08

Commit message

Corrected grammar, spelling and syntax.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sarah McCarthy +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sarah McCarthy +1
    • core-ci +1 CI

Issues 1

Files 136

Show 116 more files

Review log 3041

Show 1116 earlier messages
  1. Lina Wolf uploaded patch set 1 04/16/26, 18:58

  2. Lina Wolf marked it work in progress 04/16/26, 18:58

  3. Lina Wolf commented on patch set 1 04/16/26, 18:59

    Feature and Important tbd
  4. core-ci voted on patch set 1 V -1 04/16/26, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100342

  5. Lina Wolf uploaded patch set 2 V -1 04/17/26, 15:38

  6. core-ci voted on patch set 2 V -1 04/17/26, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100395

  7. Lina Wolf uploaded patch set 3 V -1 04/18/26, 11:14

  8. core-ci voted on patch set 3 V -1 04/18/26, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100455

  9. Lina Wolf uploaded patch set 4 V -1 04/19/26, 17:43

  10. Lina Wolf marked it ready for review 04/19/26, 17:43

  11. core-ci voted on patch set 4 V -1 04/19/26, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100490

  12. Lina Wolf uploaded patch set 5 V -1 04/20/26, 05:08

  13. core-ci voted on patch set 5 V +1 04/20/26, 05:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100503

  14. Garvin Hicking commented on patch set 5 CR -1 04/20/26, 08:38

    reviewing

    Deprecation-109329-PageRendererGetMethods.rst:17

    I would like to keep the complete names here for better searchability in search engines / LLMs.

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:122

    This here uses private, the other protected - if you change one of them, please also align the other

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:155

    please keep this

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:219

    please keep this

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:264

    please keep this
  15. Sarah McCarthy commented on patch set 5 CR -1 04/20/26, 08:41

    Currently doing a review
  16. Garvin Hicking commented on patch set 5 CR 0 04/20/26, 08:58

    If we remove this file we need to create a re

    Feature-109110-IntroduceSchedulerTaskPriority.rst:52

    Does this work with "LLL:(shortform)"? I think we'd have to remove "LLL" here?

    Feature-109130-ContextAwareEditingInPageModule.rst:1

    If we remove this file we need a changelog redirect. This is a vital file that is probably linked to from several places and maybe not using the permalink but the file-based link. Personally I would rather keep the filename, despite the "wrong" name. And just adjust the title.

    Feature-109163-Implement-public-system-resources-publishing.rst:72

    Please keep the description somewhere

    Feature-109163-Implement-public-system-resources-publishing.rst:133

    (Linebreak changes make this hard to review to scan for changes, maybe you could do that in pre-patches or not adjust linebreaks - in HTML they're irrelevant in the end)

    Feature-109271-TCAConfigurationForDynamicWizardSteps.rst:42

    See `LLL:` note in other change

    Feature-109409-Allow-configuration-of-public-resources.rst:18

    Sometimes we use `:path:` and sometimes `:folder:` do you know which one is better, to unify it? Also a few `:directory:` are also in there.
  1. Garvin Hicking commented on patch set 5 04/20/26, 08:58

    Reply

    Done
  2. Lina Wolf uploaded patch set 6 CR -1 V +1 04/20/26, 12:50

  3. Lina Wolf commented on patch set 6 04/20/26, 12:52

    Feature-109110-IntroduceSchedulerTaskPriority.rst:52 Reply

    yes that works

    Feature-109130-ContextAwareEditingInPageModule.rst:1 Reply

    Done

    Feature-109163-Implement-public-system-resources-publishing.rst:72 Reply

    Done

    Feature-109163-Implement-public-system-resources-publishing.rst:133 Reply

    Done

    Feature-109271-TCAConfigurationForDynamicWizardSteps.rst:42 Reply

    Yes that is a legal way of using the new syntax

    Feature-109409-Allow-configuration-of-public-resources.rst:18 Reply

    I think :path: is most used, changed it to that.
  4. Lina Wolf uploaded patch set 7 04/20/26, 12:56

  5. core-ci voted on patch set 6 V +1 04/20/26, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100558

  6. core-ci voted on patch set 7 V +1 04/20/26, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100560

  7. Ines Willenbrock commented on patch set 7 04/20/26, 15:19

    Part one
  8. Ines Willenbrock commented on patch set 7 04/20/26, 20:04

    Feature-105708-MultipleFileUploadForFormFramework.rst:14

    ```suggestion The TYPO3 Form Framework now supports multiple file uploads for the ``` as shown in this guide: https://docs.typo3.org/m/typo3/writing-guide/main/en-us/writing-principles-and-guidelines/spelling-and-typo3-terminology.html

    Feature-109370-ArrayBasedQueryParametersForTypolink.rst:40

    <f:link.action>` and `
  9. Lina Wolf commented on patch set 7 04/21/26, 03:08

    Deprecation-109329-PageRendererGetMethods.rst:17 Reply

    Done

    Feature-105708-MultipleFileUploadForFormFramework.rst:14 Reply

    Fix applied.

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:122 Reply

    The other one is a Controller where it is best practice to make it extendable and therefore the properties protected. Didnt know about Objecto Authorizations so left it as was, but changed it now.

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:155 Reply

    Done

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:219 Reply

    Done

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:264 Reply

    Done

    Feature-109370-ArrayBasedQueryParametersForTypolink.rst:40 Reply

    we are using the oxford comma here
  10. Lina Wolf commented on patch set 8 V +1 04/21/26, 03:12

    Published edit on patch set 7.
  11. Lina Wolf uploaded patch set 9 04/21/26, 03:14

  12. core-ci voted on patch set 9 V +1 04/21/26, 03:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100613

  13. core-ci voted on patch set 8 V +1 04/21/26, 03:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100612

  14. Garvin Hicking voted on patch set 9 CR +1 V +1 04/21/26, 04:45

  15. Garvin Hicking commented on patch set 9 04/21/26, 04:46

    Many thanks for the reworks, I see how much time went into this!
  16. Sarah McCarthy uploaded patch set 10 CR +1 V +1 04/21/26, 08:08

  17. core-ci voted on patch set 10 V -1 04/21/26, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100627

  18. Ines Willenbrock commented on patch set 10 04/21/26, 08:53

    both points ok
  19. Ines Willenbrock voted on patch set 10 V +1 04/21/26, 08:54

  20. Sarah McCarthy uploaded patch set 11 V +1 04/21/26, 08:57

  21. Sarah McCarthy commented on patch set 11 CR +1 V +1 04/21/26, 08:57

    Looks good :-)
  22. core-ci voted on patch set 11 V +1 04/21/26, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100631

  23. Benni Mack voted on patch set 11 CR +2 V +2 04/21/26, 09:08

  24. Benni Mack merged patch set 12 04/21/26, 09:08

  25. Oliver Hader voted on patch set 11 CR +1 V +1 04/21/26, 09:08