Review main Merged

93699[BUGFIX] Return modified object in PreviewUriBuilder::withRootLine

Georg Ringer CR +2 V +2 Easy +1 −1 updated 04/17/26, 16:15

Commit message

The modified object must be returned in the method instead of the
original one.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Georg Ringer uploaded patch set 1 04/16/26, 19:38

  2. Georg Ringer commented on patch set 1 04/16/26, 19:38

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/16/26, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100344

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 04/17/26, 05:08

  5. Benni Mack voted on patch set 1 CR +1 V +1 04/17/26, 05:46

  6. Oliver Klee voted on patch set 1 CR +1 04/17/26, 08:23

  7. Christian Kuhn voted on patch set 1 CR +1 V +1 04/17/26, 16:12

  8. Christian Kuhn voted on patch set 1 CR +2 V +2 04/17/26, 16:15

  9. Stefan Bürk voted on patch set 1 CR +1 V +1 04/17/26, 16:15

  10. Christian Kuhn merged patch set 2 04/17/26, 16:15