Review 13.4 Merged

93706[BUGFIX] Fix operator precedence in imageMagickExec

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 04/17/26, 08:59

Commit message

In #108933 the imageMagick command was adjusted to evaluate
whether "+matte" needs to be used for compatibility.
The syntax for one of the conditions missed proper operator
precedence, and due to concatenation failed to utilize the
proper attribute.
This patch inserts parentheses to ensure proper ternary
operator results.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Garvin Hicking commented on patch set 1 04/17/26, 08:40

    Cherry Picked from branch main.
  2. Garvin Hicking updated the commit message in patch set 2 04/17/26, 08:44

  3. core-ci voted on patch set 1 V +1 04/17/26, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100368

  4. core-ci voted on patch set 2 V +1 04/17/26, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100370

  5. Garvin Hicking voted on patch set 2 CR +2 V +2 04/17/26, 08:59

  6. Garvin Hicking merged patch set 3 04/17/26, 08:59