Review 12.4 Abandoned

93707[BUGFIX] Fix operator precedence in imageMagickExec

Garvin Hicking CR 0 V 0 Hard +546 −0 updated 04/17/26, 08:44

Commit message

In #108933 the imageMagick command was adjusted to evaluate
whether "+matte" needs to be used for compatibility.
The syntax for one of the conditions missed proper operator
precedence, and due to concatenation failed to utilize the
proper attribute.
This patch inserts parentheses to ensure proper ternary
operator results.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 2

  1. Garvin Hicking commented on patch set 1 04/17/26, 08:40

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Imaging/GifBuilder.php
  2. Garvin Hicking abandoned the change 04/17/26, 08:44

    does not affect v12