Review main Abandoned

93712[WIP][BUGFIX] Remove redundant user_settings array in FormDataProvider

Benni Mack CR -1 V 0 Easy +0 −2 updated 04/20/26, 08:23

Commit message

The UserSettingsDatabaseEditRow provider set databaseRow['user_settings']
as a decoded PHP array. Since user_settings is a json-type column in
be_users, any processing of this databaseRow entry as a column value
would JSON-encode the already-decoded array, causing double-encoded JSON.

Individual user setting fields are already populated from lines above,
making this assignment redundant.

Review

  • Code review CR -1
    • Stefan Bürk -1
  • Verified V 0
    • core-ci +1 CI

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 04/17/26, 11:38

  2. core-ci voted on patch set 1 V +1 04/17/26, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100379

  3. Benni Mack marked it ready for review 04/17/26, 12:29

  4. Christian Kuhn commented on patch set 1 04/17/26, 13:04

    Unresolved

    issue ;)
  5. Stefan Bürk commented on patch set 1 CR -1 04/17/26, 13:18

    Unresolved

    This does not resolve the "double json encoding" issue.
  6. Garvin Hicking abandoned the change 04/20/26, 08:23