Review main Merged

93713[TASK] Write Fluid schemas to a dedicated directory

Markus Klein CR +2 V +2 Normal +218 −15 updated 11/14/26, 17:15

Commit message

The `fluid:schema:generate` command wrote the generated XSD files to
`var/transient/`, next to unrelated files. They are written to the
dedicated directory `var/transient/fluid-schema/` now, and leftover
schema files in `var/transient/` are removed.

In addition, the command accepts an optional `path` argument, absolute
or relative to the project root, to write the schema files to a
directory that is picked up by the IDE.

The command fails with an error message if the directory can not be
created or a schema file can not be written, instead of reporting
success.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 3543

Show 1518 earlier messages
  1. Markus Klein uploaded patch set 1 04/17/26, 11:38

  2. core-ci voted on patch set 1 V +1 04/17/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100380

  3. Garvin Hicking commented on patch set 1 04/20/26, 05:18

    Two thoughts: - we should not introduce new top level folders in 13.4 IMO - we should make that dir configurable instead and leave it to default to that dir meaybe?
  4. Markus Klein commented on patch set 1 04/20/26, 09:41

    Reply

    > we should not introduce new top level folders in 13.4 IMO patch can be v14 only too > we should make that dir configurable instead and leave it to default to that dir meaybe? would not do that. make it a sane default and all IDEs/Tools can support that by default. If that is adjustable, then it's harder for tools.
  5. Garvin Hicking commented on patch set 1 04/20/26, 10:17

    Reply

    If we do a new top level folder, we'll need an important.rst file at least so people can adjust deployments. If we do that IMO we should not narrow such a folder down to fluid schema use. Instead we might need to create somethink like ".localConfig" / ".autogenerated" / ".ide-support" or whatever. We'll likely put more into this for MCPs and DX, AI in the future. Then fluid schemas should be a subdirectory of that. var/transient was picked more out of a "it's there, it's usually writable" choice. I agree that people often exclude it. I was under the impression the XSD files were still collected though.
  6. Markus Klein commented on patch set 1 04/21/26, 09:23

    Reply

    Just to be clear. Top-level is not a requirement! But I found no other sane folder location :-) naming: ".tool-support" would indeed be a good idea In my tests XSD were not discovered in phpstorm.
  7. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 06:46

  8. core-ci voted on patch set 2 V +1 04/22/26, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100788

  9. Matthias Vogel uploaded patch set 3 V +1 07/15/26, 07:50

  10. core-ci voted on patch set 3 V +1 07/15/26, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104780

  11. Markus Klein commented on patch set 3 07/15/26, 12:51

    Reply

    Done
  12. Markus Klein voted on patch set 3 CR +1 V +1 07/15/26, 12:52

  13. Garvin Hicking voted on patch set 3 CR +1 V +1 07/15/26, 14:52

  14. Garvin Hicking commented on patch set 3 CR 0 V 0 07/15/26, 14:56

    Rst file needs to go into 14.3.x I was told ;) (Can't move files on mobile but can do tomorrow)
  15. Simon Schaufelberger commented on patch set 3 07/15/26, 14:58

    Reply

    i can do that
  16. Simon Schaufelberger uploaded patch set 4 CR +1 V +1 07/15/26, 15:02

  17. Simon Schaufelberger voted on patch set 4 CR +1 V +1 07/15/26, 15:02

  18. Simon Schaufelberger commented on patch set 4 07/15/26, 15:02

    Reply

    Done
  1. Stefan Bürk commented on patch set 4 07/15/26, 15:03

    .tool-support/ is a folder commonly not ignored (gitignored) and possible conflicting. Additional, the . is per default a "hidden" folder and not "seen" in projects or filemanagers, which I personally not find a good approach. Special for a LTS version backport ... Some may specify them to be committed in the project repo, others not. Other option could be to make the "folder" an argument for the command and keep the current place as "sane" default being in a place on the safe side - with a possible new "default" location in v15 (main) only.
  2. core-ci voted on patch set 4 V +1 07/15/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104803

  3. Markus Klein commented on patch set 4 07/16/26, 14:34

    Reply

    I do not care too much about gitignored here. If you run the command and the files suddenly are there, one will notice and can adjust the gitignore. I think the "." is okay, as `.ddev` and `.idea` etc. follow the same pattern. I'm of course open to having this in main only
  4. Markus Klein uploaded patch set 5 CR +1 V +1 11/10/26, 08:08

  5. core-ci voted on patch set 5 V +1 11/10/26, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113856

  6. Georg Ringer uploaded patch set 6 V +1 11/12/26, 22:08

  7. Georg Ringer voted on patch set 6 CR +1 V +1 11/12/26, 22:08

  8. core-ci voted on patch set 6 V +1 11/12/26, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114251

  9. Garvin Hicking voted on patch set 6 CR +1 V +1 11/12/26, 22:37

  10. Georg Ringer commented on patch set 6 11/12/26, 22:37

    using a configurable path should make everyone happy
  11. Georg Ringer uploaded patch set 7 CR +1 V +1 11/13/26, 13:22

  12. core-ci voted on patch set 7 V +1 11/13/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114321

  13. Georg Ringer commented on patch set 7 11/13/26, 13:58

    Reply

    Done
  14. Markus Klein commented on patch set 7 CR +1 V +1 11/13/26, 13:58

    Reply

    As decided by Benni, we go with the "configurable path" version as of patchset 7
  15. Benni Mack commented on patch set 7 CR -1 11/13/26, 14:06

    I think the important part (and why should have an important rst) is that we really _NEED_ to put it in a separate folder other than var/transient, so if empty, it should go into var/transient/fluid-schema or something like that?
  16. Benni Mack uploaded patch set 8 CR +1 V +1 11/13/26, 14:32

  17. Benni Mack voted on patch set 8 CR +1 V +1 11/13/26, 15:50

  18. Garvin Hicking voted on patch set 8 CR +1 V +1 11/13/26, 16:05

  19. Benni Mack commented on patch set 8 CR -2 11/13/26, 16:06

    waiting on CI
  20. Benni Mack rebased onto patch set 9 CR +1 V +1 11/14/26, 11:25

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  21. Benni Mack voted on patch set 9 CR 0 11/14/26, 11:25

  22. core-ci voted on patch set 9 V +1 11/14/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114446

  23. Georg Ringer voted on patch set 9 CR +1 V +1 11/14/26, 12:50

  24. Benni Mack voted on patch set 9 CR +2 V +2 11/14/26, 17:15

  25. Benni Mack merged patch set 10 11/14/26, 17:15