Review main Merged

93717[BUGFIX] Avoid double encoding in workspace view

Georg Ringer CR +2 V +2 Easy +9 −10 updated 06/12/26, 06:29

Commit message

Remove various call to htmlspecialchars() to avoid double
encodings - lit does that client-side by default.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Georg Ringer uploaded patch set 1 04/17/26, 14:16

  2. Georg Ringer commented on patch set 1 04/17/26, 14:17

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/17/26, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100389

  4. Stefan Froemken commented on patch set 1 04/20/26, 16:42

    GridDataService.php:287

    IMO this line should also be removed. There is nothing which still needs sanitizing.
  5. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 06:46

  6. core-ci voted on patch set 2 V +1 04/22/26, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100794

  7. Christian Kuhn commented on patch set 2 06/11/26, 21:44

    valid patch - i played through various scenarios and found another one. key: frontend lit escapes by default so it shouldn't be escaped php-side a second time.

    GridDataService.php:287 Reply

    Done
  8. Christian Kuhn uploaded patch set 3 V +1 06/11/26, 21:45

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 06/11/26, 21:45

  10. core-ci voted on patch set 3 V +1 06/11/26, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103412

  11. Benjamin Franzke voted on patch set 3 CR +1 06/12/26, 06:09

  12. Benjamin Franzke voted on patch set 3 CR +2 V +2 06/12/26, 06:12

  13. Benjamin Franzke merged patch set 4 06/12/26, 06:29