93718[BUGFIX] Use correct access to TSconfig values
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Josua Vogel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1317
-
Georg Ringer uploaded patch set 1 04/17/26, 14:40
-
Georg Ringer commented on patch set 1 04/17/26, 14:41
This change is ready for review. -
core-ci voted on patch set 1 V +1 04/17/26, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100391
-
Josef Glatz updated the commit message in patch set 2
V +104/18/26, 01:49 -
core-ci voted on patch set 2 V -1 04/18/26, 01:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100429
-
core-ci voted on patch set 2 V +1 04/19/26, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100429
-
Garvin Hicking commented on patch set 2 CR -1 04/20/26, 09:45
Sadly we have different input methods here. If `BackendUtility::getPagesTSconfig($this->pageContext->pageId)` is utilized and passed to the create method, then the TS Config array does have the dot notation. PageLayoutController uses dotless notation, but form:be.RenderContentElementPreviewViewHelper uses that getPagesTSconfig() method. I would suggest that maybe we check for "does ['mod'] exist, then use that, else use ['mod.'] if it exists" to allow for both? Otherwise, since the DrawingConfiguration is internal we could also of course adapt the ViewHelper we use. However, EXT:templavoilaplus for example uses this internal API. -
Benni Mack wrote 04/21/26, 15:01
Removed reviewer Benni Mack. -
Benni Mack updated the commit message in patch set 3
CR -1V +104/22/26, 07:20 -
Sebastien Convers voted on patch set 3 CR +1 06/03/26, 14:49
-
Maike Kiebele uploaded patch set 4
CR +108/25/26, 08:50 -
core-ci voted on patch set 4 V +1 08/25/26, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107075
-
Garvin Hicking commented on patch set 4 CR +1 V +1 08/25/26, 17:35
Thx maike! -
Georg Ringer voted on patch set 4 CR +1 V +1 08/27/26, 14:37
-
Josua Vogel voted on patch set 4 CR +1 V +1 08/27/26, 15:09
-
Garvin Hicking voted on patch set 4 CR +2 V +2 08/27/26, 15:34
-
Garvin Hicking merged patch set 5 08/27/26, 16:05