Review main Merged

93724[BUGFIX] Address multiple flaws in form-engine based setup module

Oliver Hader CR +2 V +2 Normal +47 −73 updated 04/20/26, 06:35

Commit message

Several flaws in the SetupModuleController have been addressed:

- consolidated UserSettingsTcaConfiguration into UserSettingsSchema
  to simplify the dependency and ease discovering API capabilities
- SetupModuleController::getFieldsFromShowItem() was adjusted to
  only return real field names, previously `--div--` and similar
  where returned as defined in `showitem`
- used the correct JavaScript client event `resetConfiguration`
  (`reset_configuration` was invalid and did not trigger any action)
- dropped the `doSave` assignment as it did not appear anywhere
  in the rendered form-engine view

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Oliver Hader uploaded patch set 1 04/17/26, 21:16

  2. core-ci voted on patch set 1 V +1 04/17/26, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100415

  3. Oliver Hader commented on patch set 2 V +1 04/17/26, 21:26

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 04/17/26, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100416

  5. Oliver Hader commented on patch set 2 04/18/26, 11:41

    Basti, if could have a look please... Thank you 🙏
  6. Stefan Bürk voted on patch set 2 CR +1 V +1 04/19/26, 11:14

  7. Benni Mack voted on patch set 2 CR +1 V +1 04/20/26, 06:33

  8. Benni Mack voted on patch set 2 CR +2 V +2 04/20/26, 06:35

  9. Benni Mack merged patch set 3 04/20/26, 06:35