93726[BUGFIX] Fix double JSON encoding of backend user settings
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Oliver Hader +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/backend/Classes/Upgrades/UserSettingsMigration.php2+26 −25
- typo3/sysext/backend/Classes/Upgrades/UserSettingsNormalizationMigration.phpnew+110 −0
- typo3/sysext/backend/Tests/Functional/Upgrades/UserSettingsMigrationTest.php+69 −29
- typo3/sysext/backend/Tests/Functional/Upgrades/UserSettingsNormalizationMigrationTest.phpnew+135 −0
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+17 −2
Review log 2030
Show 35 earlier messages
-
Stefan Bürk uploaded patch set 1 04/17/26, 22:06
-
core-ci voted on patch set 1 V +1 04/17/26, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100419
-
Stefan Bürk uploaded patch set 2
V +104/17/26, 22:33 -
Stefan Bürk updated the commit message in patch set 3 04/17/26, 22:34
-
core-ci voted on patch set 2 V +1 04/17/26, 23:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100422
-
core-ci voted on patch set 3 V +1 04/17/26, 23:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100423
-
Anja Leichsenring updated the commit message in patch set 4
V +104/18/26, 04:11 -
core-ci voted on patch set 4 V -1 04/18/26, 04:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100435
-
core-ci commented on patch set 4 04/18/26, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100435
-
core-ci voted on patch set 4 V +1 04/18/26, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100435
-
Stefan Bürk updated the commit message in patch set 5
V +104/19/26, 10:16 -
Stefan Bürk marked it ready for review 04/19/26, 10:16
-
core-ci voted on patch set 5 V +1 04/19/26, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100476
-
Oliver Klee voted on patch set 5 V +1 04/19/26, 11:13
-
Garvin Hicking voted on patch set 5 CR +1 V +1 04/20/26, 07:08
-
Christian Kuhn uploaded patch set 6
CR +1V +104/20/26, 10:49 -
Christian Kuhn commented on patch set 6 V -1 04/20/26, 10:52
with applied patch, changing 'email me at login' state is not reflected after 'save' anymore, but only after new-call to module. -
core-ci voted on patch set 6 V +1 04/20/26, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100546
-
Stefan Bürk commented on patch set 6 04/20/26, 11:01
Reply
Thanks lolli. Looking into it. -
Stefan Bürk uploaded patch set 7
V +104/20/26, 14:16 -
Stefan Bürk commented on patch set 7 04/20/26, 14:19
Reply
Should be fixed now by setting it additionally `json_encode()` to the internal user record used to populate a new UserSettings object within the same request, for example to display it. -
core-ci voted on patch set 7 V -1 04/20/26, 14:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100570
-
Stefan Bürk uploaded patch set 8
V -104/20/26, 15:23 -
core-ci voted on patch set 8 V +1 04/20/26, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100577
-
Garvin Hicking commented on patch set 8 CR +1 V +1 04/20/26, 15:34
Reply
This works now! I only tested the "Personalization" checkboxes sadly, but could reproduce this and verify the fix. -
Oliver Hader voted on patch set 8 CR +1 V +1 04/20/26, 16:03
-
Stefan Bürk voted on patch set 8 CR +2 V +2 04/20/26, 16:14
-
Stefan Bürk merged patch set 9 04/20/26, 16:14
-
Benjamin Franzke commented on patch set 9 04/21/26, 10:23
UserSettingsMigration.php:80I think this caused a regression, upgrading a v13 user UC to a v14 instance causes a "PHP Warning: Array to string conversion" for me, see https://forge.typo3.org/issues/109662 -
Benjamin Franzke commented on patch set 9 04/21/26, 11:57
UserSettingsMigration.php:80ReplySorry, probably related to an unsupported MariaDB version on the instance that I tried to upgrade. (will report back if not)