Review main Merged

93728[BUGFIX] Respect "0" max files setting when rotating logs

Andreas Kienast CR +2 V +2 Easy +36 −3 updated 04/18/26, 14:32

Commit message

The documentation of `RotatingFileWriter` states [1] that setting
`maxFiles` to 0 keeps all log files after rotation, which isn't the
case right now.

This commit now checks whether the configuration is accordingly set,
including a new test to verify the bugfix.

[1] https://docs.typo3.org/permalink/t3coreapi:confval-rotating-file-writer-maxfiles

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1014

  1. Andreas Kienast uploaded patch set 1 04/18/26, 09:24

  2. Andreas Kienast uploaded patch set 2 04/18/26, 09:26

  3. Oliver Klee updated the commit message in patch set 3 04/18/26, 09:29

  4. Oliver Klee voted on patch set 3 CR +1 V +1 04/18/26, 09:29

  5. Andreas Kienast updated the commit message in patch set 4 CR +1 V +1 04/18/26, 09:29

  6. Andreas Kienast commented on patch set 4 04/18/26, 09:30

    @typo3-coding@oliverklee.de sorry, I found another typo...
  7. Oliver Klee voted on patch set 4 CR +1 V +1 04/18/26, 09:31

  8. core-ci voted on patch set 3 V +1 04/18/26, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100450

  9. core-ci voted on patch set 4 V +1 04/18/26, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100451

  10. core-ci voted on patch set 1 V +1 04/18/26, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100448

  11. Oliver Hader voted on patch set 4 CR +1 V +1 04/18/26, 10:10

  12. core-ci voted on patch set 2 V +1 04/18/26, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100449

  13. Andreas Kienast voted on patch set 4 CR +2 V +2 04/18/26, 14:32

  14. Andreas Kienast merged patch set 5 04/18/26, 14:32