Review main Merged

93729[TASK] Exclude Documentation folder from checkGruntClean

Josua Vogel CR +2 V +2 Easy +1 −1 updated 04/20/26, 09:33

Commit message

The checkGruntClean test suite removes all JavaScript files in
typo3/sysext before rebuilding them via Grunt to verify a clean
build state. The Documentation directory contains JS files that
are not part of the Grunt build pipeline and must be excluded
to avoid false negatives.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Lina Wolf +1

Issues 1

Files 1

Review log 1823

  1. Josua Vogel uploaded patch set 1 04/18/26, 11:42

  2. core-ci voted on patch set 1 V +1 04/18/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100456

  3. Josua Vogel commented on patch set 1 04/18/26, 11:53

    Please note that I need this change for the follow up
  4. Georg Ringer voted on patch set 1 CR +1 V +1 04/19/26, 12:54

  5. Lina Wolf commented on patch set 1 04/19/26, 13:15

    Why rely on this folder name which may vary and not exclude everything in the Documentation/ folder?
  6. Josua Vogel commented on patch set 1 04/19/26, 13:27

    Reply

    Yes, this would be another option. I wasn't sure
  7. Lina Wolf commented on patch set 1 04/19/26, 15:52

    Reply

    Please change to exclude the Documentation folder
  8. Josua Vogel uploaded patch set 2 CR +1 V +1 04/20/26, 06:03

  9. Josua Vogel updated the commit message in patch set 3 04/20/26, 06:04

  10. Josua Vogel commented on patch set 3 04/20/26, 06:04

    Reply

    Done
  11. core-ci voted on patch set 2 V +1 04/20/26, 06:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100504

  12. core-ci voted on patch set 3 V +1 04/20/26, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100505

  13. Garvin Hicking updated the commit message in patch set 4 V +1 04/20/26, 08:01

  14. Garvin Hicking voted on patch set 4 CR +1 V +1 04/20/26, 08:01

  15. Lina Wolf voted on patch set 4 CR +1 04/20/26, 08:02

  16. Oliver Klee voted on patch set 4 CR +1 04/20/26, 08:05

  17. core-ci voted on patch set 4 V +1 04/20/26, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100520

  18. Christian Kuhn rebased onto patch set 5 CR +1 V +1 04/20/26, 09:10

  19. Christian Kuhn voted on patch set 5 CR +2 V +2 04/20/26, 09:10

  20. Lina Wolf voted on patch set 5 CR +1 V +1 04/20/26, 09:13

  21. Garvin Hicking voted on patch set 5 CR +1 V +1 04/20/26, 09:15

  22. Garvin Hicking merged patch set 6 04/20/26, 09:15

  23. core-ci voted on patch set 5 V +1 04/20/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100536