Review main Merged

93736[BUGFIX] Fix flaky Inline1nCest acceptance test

Josua Vogel CR +2 V +2 Easy +2 −2 updated 04/20/26, 09:06

Commit message

The createInline1nInlineElement test used hard-coded
`tr:nth-child(N)` CSS selectors to verify that both the
existing "lipsum" and the newly created "Fo Bar" records
appear in the record list. The assumed row positions depend
on the database sort order, which is not guaranteed to be
stable across runs, causing intermittent test failures.

Replace the positional selectors with a simple container
check on `#recordlist-tx_styleguide_inline_1n_inline_1_child`
that only asserts the presence of both texts without requiring
a specific order. The dedicated sorting test
`checkIfCanSortingInlineElement` continues to verify exact
row positions after an explicit sort operation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Josua Vogel uploaded patch set 1 04/20/26, 06:52

  2. core-ci voted on patch set 1 V +1 04/20/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100516

  3. Oliver Klee voted on patch set 1 CR +1 04/20/26, 07:22

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 04/20/26, 07:46

    lgtm
  5. Oliver Klee voted on patch set 1 V +1 04/20/26, 07:51

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 04/20/26, 09:06

  7. Christian Kuhn commented on patch set 1 04/20/26, 09:06

    thank you!
  8. Christian Kuhn merged patch set 2 04/20/26, 09:06