Review main Merged

93746[BUGFIX] Re-add `array_values()` in `SchemaMigrator`

Stefan Bürk CR +2 V +2 Easy +19 −8 updated 04/20/26, 10:56

Commit message

The change in #108946 removed `array_values()` calls from
`SchemaMigrator::mergeTableDefinitions()` to fix PHPStan
`arrayValues.list` issues.

This breaks index merging and may trigger PHP errors like:

  Named parameter $index_name overwrites previous argument

To circumvent the issue, the following actions have been taken:

* Restore required `array_values()` calls for index handling.
* Adjust functional tests for `mergeTableDefinitions()` to
  also cover index merging.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Stefan Bürk uploaded patch set 1 04/20/26, 09:48

  2. Garvin Hicking voted on patch set 1 CR +1 V +1 04/20/26, 10:02

  3. Oliver Klee voted on patch set 1 CR +1 V +1 04/20/26, 10:07

  4. core-ci voted on patch set 1 V +1 04/20/26, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100543

  5. Stefan Bürk voted on patch set 1 CR -1 04/20/26, 10:18

  6. Christian Kuhn voted on patch set 1 CR +1 V +1 04/20/26, 10:55

  7. Stefan Bürk voted on patch set 1 CR +2 V +2 04/20/26, 10:56

  8. Stefan Bürk merged patch set 2 04/20/26, 10:56