Review main Merged

93747[BUGFIX] Connect label and filter input in selectMultipleSideBySide

Christian Rath-Ulrich CR +2 V +2 Easy +3 −2 updated 04/27/26, 18:10

Commit message

A unique identifier is generated for the multiselect filter field
and used to link the existing label via for/id. This restores a
proper programmatic label-input relationship, improving screen
reader announcements and allowing label click-to-focus behavior
for better accessibility.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Jung +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Jung +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1723

  1. Christian Rath-Ulrich uploaded patch set 1 04/20/26, 11:17

  2. core-ci voted on patch set 1 V +1 04/20/26, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100548

  3. Stefan Bürk updated the commit message in patch set 2 V +1 04/20/26, 14:29

  4. Stefan Bürk commented on patch set 2 04/20/26, 14:31

    @christian@rath-ulrich.de can you please write one or two sentenace describing why this is needed / the impact / what it archives ? (hinting that unique field identifier is created and used)
  5. core-ci voted on patch set 2 V +1 04/20/26, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100573

  6. Christian Rath-Ulrich updated the commit message in patch set 3 V +1 04/20/26, 14:57

  7. Christian Rath-Ulrich commented on patch set 3 04/20/26, 14:57

    Reply

    Done
  8. core-ci voted on patch set 3 V +1 04/20/26, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100575

  9. Georg Ringer voted on patch set 3 CR +1 V +1 04/20/26, 15:54

  10. Stefan Froemken commented on patch set 3 CR +1 V +1 04/20/26, 17:01

    Tested with the available items of frontend groups. Looks good.
  11. Christian Kuhn commented on patch set 3 04/20/26, 19:14

    linebreaks
  12. Christian Kuhn rebased onto patch set 4 CR +1 V +1 04/20/26, 19:42

  13. Christian Kuhn rebased onto patch set 5 04/20/26, 19:43

  14. Christian Kuhn commented on patch set 5 04/20/26, 19:43

    Reply

    Done
  15. core-ci voted on patch set 4 V +1 04/20/26, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100599

  16. core-ci voted on patch set 5 V +1 04/20/26, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100600

  17. Garvin Hicking voted on patch set 5 CR +1 V +1 04/20/26, 19:57

  18. Stefan Froemken voted on patch set 5 CR +1 V +1 04/20/26, 20:11

  19. Benni Mack updated the commit message in patch set 6 CR +1 V +1 04/22/26, 06:46

  20. core-ci voted on patch set 6 V +1 04/22/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100792

  21. Christian Jung commented on patch set 6 CR +1 V +1 04/27/26, 16:01

    Tested with Frontend User Group. “Available Items” is announced by VoiceOver now.
  22. Garvin Hicking voted on patch set 6 CR +2 V +2 04/27/26, 17:50

  23. Garvin Hicking merged patch set 7 04/27/26, 18:10