93749[BUGFIX] Combine mtime and filesize for package cache identifier
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Helmut Hummel +1
-
Verified V +2 Done
- Stefan Bürk +2
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2836
Show 911 earlier messages
-
Benjamin Kott uploaded patch set 1 04/20/26, 11:33
-
core-ci voted on patch set 1 V +1 04/20/26, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100551
-
Benjamin Kott rebased onto patch set 2
V +104/20/26, 12:07 -
Christian Kuhn voted on patch set 2 CR +1 V +1 04/20/26, 12:15
-
core-ci voted on patch set 2 V +1 04/20/26, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100554
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 04/20/26, 12:27
-
Christian Kuhn voted on patch set 2 CR 0 V 0 04/20/26, 12:40
-
Christian Kuhn commented on patch set 2 04/20/26, 12:44
This is bootstrap hot-path. For every requestPackageStatesPackageCache.php:84This is bootstrap hot-path. For every request. The file is small and xxh3 is ultra fast, the impact is low. However, combination of mtime+filesize would shift the operation to file metadata only, which is more easy for kernel to cache. Should we consider this option? It should solve the race condition as well. -
Benjamin Kott commented on patch set 2 04/20/26, 13:05
PackageStatesPackageCache.php:84Replyi consider it unlikely that we for some reason manage to have it in the same second and manage to produce somehow the same filesize. so, this can also be an option. i am not sure about this, only pinpointed the problem and having a solution. we are using xxh3 in some other places too for similar checks. -
Benjamin Kott commented on patch set 2 04/20/26, 13:18
PackageStatesPackageCache.php:84Replyplease go ahead and adjust if needed -
Christian Kuhn uploaded patch set 3
CR +1V +104/20/26, 13:49
-
Christian Kuhn commented on patch set 3 04/20/26, 13:50
PackageStatesPackageCache.php:84ReplyDone -
Christian Kuhn voted on patch set 3 CR -1 04/20/26, 13:56
-
core-ci voted on patch set 3 V +1 04/20/26, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100569
-
Christian Kuhn commented on patch set 3 04/20/26, 14:45
will take care of a minor detail. stay tuned. -
Christian Kuhn uploaded patch set 4
CR -1V +104/20/26, 16:04 -
Christian Kuhn voted on patch set 4 CR +1 V +1 04/20/26, 16:04
-
Helmut Hummel commented on patch set 4 CR -2 04/20/26, 16:14
I think this is not necessary -
core-ci voted on patch set 4 V -1 04/20/26, 16:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100579
-
Helmut Hummel commented on patch set 4 CR +1 V +1 04/20/26, 16:33
oops sorry. thought this would still do a full content hash. using filesize stat is pretty smart, thanks Is there a reason this does not affect older branches as well? -
Helmut Hummel commented on patch set 4 CR 0 04/20/26, 16:36
PackageStatesPackageCacheTest.php:66why this touch call?PackageStatesPackageCacheTest.php:67why clear the realpath cache as well? -
core-ci voted on patch set 4 V +1 04/20/26, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100579
-
Christian Kuhn commented on patch set 4 V 0 CR -1 04/20/26, 17:08
will push.PackageStatesPackageCacheTest.php:66Replyphp caches stat() internally. the call ensures both assertions actually ensure on-disk state.PackageStatesPackageCacheTest.php:67Replyyeah. that's not necessary. -
Christian Kuhn commented on patch set 4 04/20/26, 17:12
PackageStatesPackageCacheTest.php:66Replyso touch() takes care of internal php caches, and clearstatcache() is not needed. good catch. thx! -
Christian Kuhn commented on patch set 4 04/20/26, 17:12
PackageStatesPackageCacheTest.php:67ReplyDone -
Christian Kuhn uploaded patch set 5
CR -1V +104/20/26, 17:13 -
Christian Kuhn commented on patch set 5 04/20/26, 17:15
Reply
yes. v13 backport is a good idea. -
Christian Kuhn updated the commit message in patch set 6 04/20/26, 17:15
-
Christian Kuhn voted on patch set 6 CR +1 V +1 04/20/26, 17:15
-
core-ci voted on patch set 5 V -1 04/20/26, 17:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100589
-
core-ci voted on patch set 6 V -1 04/20/26, 17:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100590
-
Helmut Hummel uploaded patch set 7
CR +1V +104/20/26, 17:26 -
Helmut Hummel voted on patch set 7 CR +1 V +1 04/20/26, 17:26
-
core-ci voted on patch set 7 V +1 04/20/26, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100591
-
Stefan Bürk voted on patch set 7 CR +2 V +2 04/20/26, 18:09
-
Stefan Bürk merged patch set 8 04/20/26, 18:09