Review main Merged

93754[BUGFIX] Restore position arrows in new page wizard after filtering

Benjamin Kott CR +2 V +2 Normal +82 −50 updated 04/20/26, 18:56

Commit message

Tree.filter() replaces the tree's nodeMap with the server
response, which does not contain the client-side -inside and
-after nodes that render the positioning arrows for the active
page in the new page wizard.

Dispatch dedicated TreeFilterAppliedEvent and TreeFilterResetEvent
events once filter() and resetFilter() have settled, and re-apply
the dynamic insert nodes for the active page from
PagePositionSelect when either fires.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Benjamin Kott uploaded patch set 1 04/20/26, 14:24

  2. core-ci voted on patch set 1 V +1 04/20/26, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100572

  3. Stefan Froemken commented on patch set 1 V +1 04/20/26, 18:08

    I am not familiar with TypeScript, so I will stick to a Verified vote for now. The insertion arrows are appearing correctly again, specifically for sibling pages at the same level as the selected page. If a page on level 2 is selected and the search is used, results from the root level may appear without arrows. This behavior seems correct, as the arrows should only be visible for records on the same level as the initial selection. The Page Creation Wizard now behaves as expected in this scenario.
  4. Christian Kuhn voted on patch set 1 CR +1 V +1 04/20/26, 18:32

  5. Benni Mack voted on patch set 1 CR +2 V +2 04/20/26, 18:56

  6. Benni Mack merged patch set 2 04/20/26, 18:56