Review main Merged

93756[BUGFIX] Allow datetime field usage in page creation wizard

Benjamin Franzke CR +2 V +2 Normal +62 −57 updated 04/20/26, 19:17

Commit message

The FormEngine datetime field's calendar previously attached to
document.body and relied on flatpickr's floating positioning. Inside
modal dialogs such as the page creation wizard the calendar rendered
outside the dialog's top-layer and ended up covered by the modal
backdrop, leaving the field unusable.

The calendar now renders inside its <typo3-formengine-element-datetime>
host and is shown via the native Popover API, with placement driven by
CSS anchor positioning. The browser handles top-layer stacking above
open modal dialogs and tracks the anchored input on scroll and resize
natively. Scrolling the nearest scrollable ancestor dismisses the
popover.

Other consumers of the DateTimePicker module (belog, lowlevel) keep the
legacy reposition-on-scroll behaviour, but now bind the scroll listener
against the nearest scrollable ancestor via DomHelper.scrollEventTarget
instead of the hardcoded `.t3js-module-body`. The unused styleguide
filter module that only ever looked for non-existent
`.t3js-datetimepicker` inputs is removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1014

  1. Benjamin Franzke uploaded patch set 1 04/20/26, 15:58

  2. core-ci voted on patch set 1 V -1 04/20/26, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100578

  3. Benjamin Franzke uploaded patch set 2 V -1 04/20/26, 17:31

  4. Benjamin Kott uploaded patch set 3 04/20/26, 17:33

  5. Benjamin Kott commented on patch set 3 04/20/26, 17:33

    This change is ready for review.
  6. Benjamin Kott voted on patch set 3 CR +1 V +1 04/20/26, 17:43

  7. core-ci voted on patch set 3 V -1 04/20/26, 17:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100594

  8. core-ci voted on patch set 2 V -1 04/20/26, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100593

  9. Benjamin Kott uploaded patch set 4 CR +1 V +1 04/20/26, 18:19

  10. core-ci voted on patch set 4 V +1 04/20/26, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100597

  11. Christian Kuhn voted on patch set 4 V +1 04/20/26, 18:36

  12. Benjamin Kott voted on patch set 4 CR +1 V +1 04/20/26, 18:55

  13. Benni Mack voted on patch set 4 CR +2 V +2 04/20/26, 19:10

  14. Benni Mack merged patch set 5 04/20/26, 19:17