Review main Merged

93777[BUGFIX] Calculate sorting of copied records from destination

Friedemann Altrock CR +2 V +2 Normal +56 −0 updated 11/13/26, 08:23

Commit message

When a record is copied, DataHandler hands all fields of the source
record that are configured in TCA `columns` to a new datamap. If the
`sortby` field of a table is configured as a column, for example to
make it available in an Extbase model, the sorting value of the
source record was part of that datamap and replaced the value that
was calculated for the destination. The copy then ended up next to
its source record instead of at the top of the target page or after
the record it was pasted after.

The `sortby` field of the source record is now left out when the
datamap for the copy is built, so the sorting is always calculated
from the destination. A sorting value that is explicitly passed in a
datamap is handled as before.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 813

  1. Friedemann Altrock uploaded patch set 1 04/21/26, 10:44

  2. core-ci voted on patch set 1 V +1 04/21/26, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100634

  3. Friedemann Altrock uploaded patch set 2 V +1 04/21/26, 11:13

  4. core-ci voted on patch set 2 V +1 04/21/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100635

  5. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 06:50

  6. core-ci voted on patch set 3 V +1 04/22/26, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100811

  7. Benni Mack rebased onto patch set 4 V +1 11/12/26, 21:03

  8. core-ci voted on patch set 4 V -1 11/12/26, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114238

  9. Benni Mack uploaded patch set 5 V -1 11/12/26, 21:42

  10. Benni Mack voted on patch set 5 CR +1 V +1 11/12/26, 21:44

  11. core-ci voted on patch set 5 V +1 11/12/26, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114248

  12. Georg Ringer voted on patch set 5 CR +2 V +2 11/13/26, 06:35

  13. Benni Mack merged patch set 6 11/13/26, 08:23