Review main Merged

93779[BUGFIX] Honor insertPosition in page creation wizard

Benjamin Kott CR +2 V +2 Normal +110 −3 updated 04/22/26, 06:40

Commit message

The page wizard always passed the reference page uid as a
positive pid to DataHandler, so selecting "after" silently
degraded to "inside". Submit now uses a negative pid when the
position is "after", and the configuration step resolves the
actual parent page uid so FormDataCompiler evaluates
pageTSConfig, permissions and defaults against the correct
parent.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Benjamin Kott uploaded patch set 1 04/21/26, 11:47

  2. Benjamin Kott commented on patch set 1 CR -1 04/21/26, 11:56

    adding tests
  3. Benjamin Kott uploaded patch set 2 CR -1 04/21/26, 12:16

  4. Benjamin Kott commented on patch set 2 04/21/26, 12:17

    Reply

    Done
  5. core-ci voted on patch set 1 V +1 04/21/26, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100637

  6. core-ci voted on patch set 2 V +1 04/21/26, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100639

  7. Benni Mack voted on patch set 2 CR +1 V +1 04/21/26, 13:45

  8. Georg Ringer voted on patch set 2 CR +2 V +2 04/22/26, 06:40

  9. Georg Ringer merged patch set 3 04/22/26, 06:40